You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Ivan Kelly <iv...@apache.org> on 2012/03/19 12:37:21 UTC
Review Request: BOOKKEEPER-187 Create well defined interface for LedgerCache
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4403/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
This addresses bug BOOKKEEPER-187.
https://issues.apache.org/jira/browse/BOOKKEEPER-187
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6e47c08
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java c514f6d
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java ba9c6d4
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java d14f373
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 87a1e66
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java 6e64932
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java c4eacda
Diff: https://reviews.apache.org/r/4403/diff
Testing
-------
Thanks,
Ivan
Re: Review Request: BOOKKEEPER-187 Create well defined interface for
LedgerCache
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4403/#review6112
-----------------------------------------------------------
Ship it!
the patch looks good to me. +1.
- Sijie
On 2012-03-19 11:37:21, Ivan Kelly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4403/
> -----------------------------------------------------------
>
> (Updated 2012-03-19 11:37:21)
>
>
> Review request for bookkeeper.
>
>
> Summary
> -------
>
> Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
>
>
> This addresses bug BOOKKEEPER-187.
> https://issues.apache.org/jira/browse/BOOKKEEPER-187
>
>
> Diffs
> -----
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6e47c08
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java c514f6d
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java ba9c6d4
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java d14f373
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 87a1e66
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java 6e64932
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java c4eacda
>
> Diff: https://reviews.apache.org/r/4403/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan
>
>