[GitHub] [helix] desaikomal commented on a diff in pull request #2384: Use JDK 11 for Helix Project

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1119550539


##########
.github/workflows/Helix-CI.yml:
##########
@@ -12,14 +12,14 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up JDK 1.8
+    - name: Set up JDK 11
       uses: actions/setup-java@v1
       with:
-        java-version: 1.8
+        java-version: 11
     - name: Build with Maven
-      run: mvn clean install -Dmaven.test.skip.exec=true -DretryFailedDeploymentCount=5

Review Comment:
   i accidently had removed the modification. re-introduced with latest change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org