[jira] [Updated] (OAK-659) Move purge logic for transient changes below the NodeBuilder interface

["Michael Dürig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig updated OAK-659:
------------------------------

    Attachment: OAK-659.patch

WIP patch. The KernelNodeStore specific tests pass with this. Other tests fail with a {{ClassCastException}} at {{RootImpl#rebase}} where a temporary work around is in place. 

The main remaining issue is how to implement {{RootImpl#rebase}} and {{RootImpl#reset}} since {{NodeBuilder}} does not expose such functionality but {{KernelRootBuilder}} hides the functionality for resetting and rebasing in {{NodeStoreBranch}}. 

[~jukkaz] do you have an idea here?
                
> Move purge logic for transient changes below the NodeBuilder interface
> ----------------------------------------------------------------------
>
>                 Key: OAK-659
>                 URL: https://issues.apache.org/jira/browse/OAK-659
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>         Attachments: OAK-659.patch
>
>
> Currently transient changes are purged down to a persisted branch once a certain size threshold is hit. This logic currently resides in {{RootImpl}}. However this approach doesn't catch the case where a lot of content is added by a commit hook (e.g. index updates) since commit hooks operate on the {{NodeBuilder}} level which is below {{Root}}. 
> The aim of this issue is to pursue ways to push the purge logic further down below the {{NodeBuilder}} interface. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira