You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/06/25 19:19:44 UTC

[jira] [Updated] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default

     [ https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-6267:
----------------------------------

    Affects Version/s: 0.94.1
                       0.96.0
        Fix Version/s:     (was: 0.94.1)
                           (was: 0.96.0)
    
> hbase.store.delete.expired.storefile should be true by default
> --------------------------------------------------------------
>
>                 Key: HBASE-6267
>                 URL: https://issues.apache.org/jira/browse/HBASE-6267
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.96.0, 0.94.1
>            Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> +      // Delete the expired store files before the compaction selection.
> +      if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> +          && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +        CompactSelection expiredSelection = compactSelection
> +            .selectExpiredStoreFilesToCompact(
> +                EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +        // If there is any expired store files, delete them  by compaction.
> +        if (expiredSelection != null) {
> +          return expiredSelection;
> +        }
> +      }
> {code}
> Is there any reason why that should not be default {{true}}?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira