You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/04/04 15:47:42 UTC
[GitHub] [arrow] wgtmac opened a new pull request, #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
wgtmac opened a new pull request, #34889:
URL: https://github.com/apache/arrow/pull/34889
### Rationale for this change
Parquet specs support storing key-value metadata provided by the user. However, the parquet-cpp writer can only set it via ParquetFileWriter::Open(). Sometimes user may want to add extra information to it while writing. So it is good to support adding extra key-value metadata any time before closing the file writer.
### What changes are included in this PR?
Add a new interface `void AddKeyValueMetadata(std::shared_ptr<const KeyValueMetadata> key_value_metadata)` to the `ParquetFileWriter` class. User can now add more key-value metadata to the file if not closed.
### Are these changes tested?
Added a new `Metadata.TestAddKeyValueMetadata` test to verify key-value metadata added before closing the writer are well preserved.
### Are there any user-facing changes?
Yes, user can add custom key-value metadata whenever writer is not closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161375853
##########
cpp/src/parquet/file_writer.h:
##########
@@ -209,6 +212,12 @@ class PARQUET_EXPORT ParquetFileWriter {
/// until the next call to AppendRowGroup or AppendBufferedRowGroup or Close.
RowGroupWriter* AppendBufferedRowGroup();
+ /// \brief Add key-value metadata to the file.
+ /// \param[in] key_value_metadata the metadata to add.
+ /// \note This will overwrite any existing metadata with the same key.
+ /// It will not take effect if Close() has been called.
Review Comment:
Good point! Fixed
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -356,6 +355,15 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ std::shared_ptr<const KeyValueMetadata> key_value_metadata) override {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #34889:
URL: https://github.com/apache/arrow/pull/34889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1500134878
@wjones127 @westonpace Please take a look when you have time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1506620643
> @raulcd would it be possible to add this to the release branch?
I will add it to 12.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1496212272
:warning: GitHub issue #34888 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1509925074
Benchmark runs are scheduled for baseline = 49631057e9cdbf991e11e0be4b9aa0dadf616850 and contender = 3bd57e35cc949bce6a04d7fbfed30c6db755b023. 3bd57e35cc949bce6a04d7fbfed30c6db755b023 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/005ff6d16314498d951bfbd6b2ea7307...1cb0f2f669cf4cd4a426d0e0cb8ddcfe/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b16aedf5b8cc49bb83363102e9f9fec5...11271443d9b5466c8198193e9345efb0/)
[Finished :arrow_down:20.92% :arrow_up:1.53%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ce73eac2f0242ddab514bbf7a491d62...cfe43059b9884378ab07cdbb91b195c2/)
[Finished :arrow_down:1.11% :arrow_up:0.12%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d188845fbfbe430cac94df48665711f7...cf92bbd807b545c09c7b5c30c074a3be/)
Buildkite builds:
[Finished] [`3bd57e35` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2705)
[Failed] [`3bd57e35` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2739)
[Finished] [`3bd57e35` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2703)
[Finished] [`3bd57e35` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2730)
[Finished] [`49631057` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2704)
[Failed] [`49631057` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2738)
[Finished] [`49631057` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2702)
[Finished] [`49631057` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2729)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161021525
##########
cpp/src/parquet/metadata.h:
##########
@@ -510,24 +510,23 @@ class PARQUET_EXPORT FileMetaDataBuilder {
public:
// API convenience to get a MetaData reader
static std::unique_ptr<FileMetaDataBuilder> Make(
- const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props,
- std::shared_ptr<const KeyValueMetadata> key_value_metadata = NULLPTR);
+ const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props);
Review Comment:
I know it makes the code more complex, but I think for now we should create a new overload that drops the `key_value_metadata` parameter and add `PARQUET_DEPRECATED` marker to the existing constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161101486
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -356,6 +355,15 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ std::shared_ptr<const KeyValueMetadata> key_value_metadata) override {
+ if (key_value_metadata_ == nullptr) {
+ key_value_metadata_ = std::move(key_value_metadata);
+ } else if (key_value_metadata != nullptr) {
+ key_value_metadata_ = key_value_metadata_->Merge(*key_value_metadata);
Review Comment:
should we add a DCHECK for `key_value_metadata != nullptr`?
##########
cpp/src/parquet/file_writer.h:
##########
@@ -209,6 +212,12 @@ class PARQUET_EXPORT ParquetFileWriter {
/// until the next call to AppendRowGroup or AppendBufferedRowGroup or Close.
RowGroupWriter* AppendBufferedRowGroup();
+ /// \brief Add key-value metadata to the file.
+ /// \param[in] key_value_metadata the metadata to add.
+ /// \note This will overwrite any existing metadata with the same key.
+ /// It will not take effect if Close() has been called.
Review Comment:
Should we throw ex if closed?
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -356,6 +355,15 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ std::shared_ptr<const KeyValueMetadata> key_value_metadata) override {
Review Comment:
Should it better be a `const std::shared_ptr<const KeyValueMetadata>& key_value_metadata`? Because it doesn't force copy everytime
##########
cpp/src/parquet/metadata.h:
##########
@@ -510,24 +510,23 @@ class PARQUET_EXPORT FileMetaDataBuilder {
public:
// API convenience to get a MetaData reader
static std::unique_ptr<FileMetaDataBuilder> Make(
- const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props,
- std::shared_ptr<const KeyValueMetadata> key_value_metadata = NULLPTR);
+ const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props);
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1506150623
I merged this and then realized I have just missed the window for 12.0.0. @raulcd would it be possible to add this to the release branch? Otherwise I'll put up a PR to adjust the text of the deprecation warning added in this PR (which says a method was deprecated in 12.0.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161375395
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1743,13 +1743,11 @@ void RowGroupMetaDataBuilder::Finish(int64_t total_bytes_written,
// TODO(PARQUET-595) Support key_value_metadata
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1496212204
* Closes: #34888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161020025
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1743,13 +1743,11 @@ void RowGroupMetaDataBuilder::Finish(int64_t total_bytes_written,
// TODO(PARQUET-595) Support key_value_metadata
Review Comment:
I think we can remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1163222982
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -376,6 +377,16 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ const std::shared_ptr<const KeyValueMetadata>& key_value_metadata) override {
+ if (key_value_metadata_ == nullptr) {
+ key_value_metadata_ = std::move(key_value_metadata);
+ } else if (key_value_metadata != nullptr) {
+ ARROW_DCHECK(key_value_metadata != nullptr);
Review Comment:
That seems unnecessary
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161375739
##########
cpp/src/parquet/metadata.h:
##########
@@ -510,24 +510,23 @@ class PARQUET_EXPORT FileMetaDataBuilder {
public:
// API convenience to get a MetaData reader
static std::unique_ptr<FileMetaDataBuilder> Make(
- const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props,
- std::shared_ptr<const KeyValueMetadata> key_value_metadata = NULLPTR);
+ const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props);
Review Comment:
Sounds reasonable. Fixed.
The only caveat is that the old overload simply ignores the input `key_value_metadata` which may confuses users.
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -356,6 +355,15 @@ class FileSerializer : public ParquetFileWriter::Contents {
RowGroupWriter* AppendBufferedRowGroup() override { return AppendRowGroup(true); }
+ void AddKeyValueMetadata(
+ std::shared_ptr<const KeyValueMetadata> key_value_metadata) override {
+ if (key_value_metadata_ == nullptr) {
+ key_value_metadata_ = std::move(key_value_metadata);
+ } else if (key_value_metadata != nullptr) {
+ key_value_metadata_ = key_value_metadata_->Merge(*key_value_metadata);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1502024663
Fixed it to be backward compatible. Please take a look again. Thanks! @wjones127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1509925229
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ce73eac2f0242ddab514bbf7a491d62...cfe43059b9884378ab07cdbb91b195c2/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1161837285
##########
cpp/src/parquet/metadata.h:
##########
@@ -508,26 +508,29 @@ class PARQUET_EXPORT RowGroupMetaDataBuilder {
class PARQUET_EXPORT FileMetaDataBuilder {
public:
- // API convenience to get a MetaData reader
+ // API convenience to get a MetaData builder
+ PARQUET_DEPRECATED("Deprecated. Use overload without KeyValueMetadata instead.")
Review Comment:
It's nice to say when it was deprecated.
```suggestion
PARQUET_DEPRECATED("Deprecated in 12.0.0. Use overload without KeyValueMetadata instead.")
```
##########
cpp/src/parquet/metadata.h:
##########
@@ -510,24 +510,23 @@ class PARQUET_EXPORT FileMetaDataBuilder {
public:
// API convenience to get a MetaData reader
static std::unique_ptr<FileMetaDataBuilder> Make(
- const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props,
- std::shared_ptr<const KeyValueMetadata> key_value_metadata = NULLPTR);
+ const SchemaDescriptor* schema, std::shared_ptr<WriterProperties> props);
Review Comment:
Ignoring the parameter seems like an even worse breaking change than removing it. Could we simply make this backwards compatible? Either `key_value_metadata` in `Finish` in override, or it should merge with the one provided in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on a diff in pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #34889:
URL: https://github.com/apache/arrow/pull/34889#discussion_r1163497420
##########
cpp/src/parquet/metadata.h:
##########
@@ -523,10 +523,14 @@ struct PageIndexLocation {
class PARQUET_EXPORT FileMetaDataBuilder {
public:
- // API convenience to get a MetaData reader
+ ARROW_DEPRECATED("Deprecated in 12.0.0. Use overload without KeyValueMetadata instead.")
Review Comment:
```suggestion
ARROW_DEPRECATED("Deprecated in 13.0.0. Use overload without KeyValueMetadata instead.")
```
Should I change this since it may not be included in the 12.0.0 release? @wjones127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #34889: GH-34888: [C++][Parquet] Writer supports adding extra kv meta
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #34889:
URL: https://github.com/apache/arrow/pull/34889#issuecomment-1502580631
https://github.com/apache/arrow/actions/runs/4662936307/jobs/8253813543?pr=34889 is failing:
```
+ doxygen
/arrow/cpp/apidoc /
warning: Tag 'OUTPUT_TEXT_DIRECTION' at line 119 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'COLS_IN_ALPHA_INDEX' at line 1118 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'FORMULA_TRANSPARENT' at line 1557 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'LATEX_SOURCE_CODE' at line 1865 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'RTF_SOURCE_CODE' at line 1955 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOCBOOK_PROGRAMLISTING' at line 2060 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'CLASS_DIAGRAMS' at line 2257 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTNAME' at line 2299 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTSIZE' at line 2306 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_TRANSPARENT' at line 2530 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
/arrow/cpp/src/parquet/metadata.h:531: error: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon) (warning treated as error, aborting now)
1
Error: `docker-compose --file /home/runner/work/arrow/arrow/docker-compose.yml run --rm conda-python-docs` exited with a non-zero exit code 1, see the process log above.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org