You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "acassis (via GitHub)" <gi...@apache.org> on 2024/06/09 10:15:52 UTC
[PR] Makefile: Fix missing brackets [nuttx]
acassis opened a new pull request, #12479:
URL: https://github.com/apache/nuttx/pull/12479
## Summary
These issue were found by Georgi Angelov while porting NuttX to use on PlatformIO.
## Impact
Fixes
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Makefile: Fix missing brackets [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12479:
URL: https://github.com/apache/nuttx/pull/12479#discussion_r1632642689
##########
arch/arm/src/Makefile:
##########
@@ -190,7 +190,7 @@ EXTRA_LIBS += allsyms$(OBJEXT)
endif
define LINK_ALLSYMS_KASAN
- $(if $(CONFIG_ALLSYMS),
+ $(if $(CONFIG_ALLSYMS),)
Review Comment:
no, please watch ci or change your change locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Makefile: Fix missing brackets [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12479:
URL: https://github.com/apache/nuttx/pull/12479#discussion_r1632312553
##########
arch/arm/src/Makefile:
##########
@@ -190,7 +190,7 @@ EXTRA_LIBS += allsyms$(OBJEXT)
endif
define LINK_ALLSYMS_KASAN
- $(if $(CONFIG_ALLSYMS),
+ $(if $(CONFIG_ALLSYMS),)
Review Comment:
Normally it is "$(if $(CONFIG_ALLSYMS), something, etc)", the "$(if" normally needs a closing ")"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Makefile: Fix missing brackets [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12479:
URL: https://github.com/apache/nuttx/pull/12479#discussion_r1632256478
##########
arch/arm/src/Makefile:
##########
@@ -190,7 +190,7 @@ EXTRA_LIBS += allsyms$(OBJEXT)
endif
define LINK_ALLSYMS_KASAN
- $(if $(CONFIG_ALLSYMS),
+ $(if $(CONFIG_ALLSYMS),)
Review Comment:
but it's the right if make expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Makefile: Fix missing brackets [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12479:
URL: https://github.com/apache/nuttx/pull/12479#discussion_r1633465390
##########
arch/arm/src/Makefile:
##########
@@ -190,7 +190,7 @@ EXTRA_LIBS += allsyms$(OBJEXT)
endif
define LINK_ALLSYMS_KASAN
- $(if $(CONFIG_ALLSYMS),
+ $(if $(CONFIG_ALLSYMS),)
Review Comment:
Oh ok, I saw the issue! I'll close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Makefile: Fix missing brackets [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis closed pull request #12479: Makefile: Fix missing brackets
URL: https://github.com/apache/nuttx/pull/12479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org