[GitHub] [spark] cloud-fan commented on a change in pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31390:
URL: https://github.com/apache/spark/pull/31390#discussion_r578483883



##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/strings.sql
##########
@@ -647,7 +647,9 @@ SELECT repeat('Pg', 4);
 SELECT repeat('Pg', -4);
 
 SELECT trim(binary('\\000') from binary('\\000Tom\\000'));
--- [SPARK-28123] Add support btrim
+SELECT btrim(binary('\\000trim\\000'), binary('\\000'));
+SELECT btrim(binary(''), binary('\\000'));
+SELECT btrim(binary('\\000trim\\000'), binary(''));
 -- SELECT btrim(E'\\000trim\\000'::bytea, E'\\000'::bytea);
 -- SELECT btrim(''::bytea, E'\\000'::bytea);
 -- SELECT btrim(E'\\000trim\\000'::bytea, ''::bytea);

Review comment:
       shall we remove the above 3 lines?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org