You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Greg Ames <gr...@remulak.net> on 2001/07/11 20:04:38 UTC

Re: cvs commit: apr/include apr_pools.h apr_sms.h

dreid@apache.org wrote:
> 
> dreid       01/07/11 07:20:31
> 
>   Modified:    .        configure.in
>                memory/unix apr_sms.c sms_private.h
>                include  apr_pools.h apr_sms.h

Whoops! seems to have broken the build:

/bin/sh /home/gregames/apache/httpd-2.0/srclib/apr/libtool --silent
--mode=compile gcc  -g -O2 -Wall -Wmissing-prototypes
-Wstrict-prototypes -Wmissing-declarations -pthread
-DNO_DBM_REWRITEMAP    -DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -DAP_DEBUG
-DAP_HAVE_DESIGNATED_INITIALIZER   -I.
-I/home/gregames/apache/httpd-2.0/os/unix
-I/home/gregames/apache/httpd-2.0/server/mpm/prefork
-I/home/gregames/apache/httpd-2.0/modules/http
-I/home/gregames/apache/httpd-2.0/include
-I/home/gregames/apache/httpd-2.0/srclib/apr/include
-I/home/gregames/apache/httpd-2.0/srclib/apr-util/include -c exports.c
&& touch exports.lo
exports.c:342: `apr_sms_dump_stats' undeclared here (not in a function)
make[2]: *** [exports.lo] Error 1
make[2]: Leaving directory `/home/gregames/apache/httpd-2.0/server'

It's the following:
 
>   Index: apr_sms.h
>   ===================================================================

>    APR_DECLARE(void) apr_sms_tag(apr_sms_t *sms, const char *tag);
>    #endif /* APR_DEBUG_TAG_SMS */
>   +
>   +#if SMS_ALLOC_STATS
>   +APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
>   +#endif
> 

make_export.awk doesn't seem to deal with this #if as one might hope. 
Commenting out the APR_DECLARE gets me building again:

Index: srclib/apr/include/apr_sms.h
===================================================================
RCS file: /cvs/apache/apr/include/apr_sms.h,v
retrieving revision 1.37
diff -u -d -b -r1.37 apr_sms.h
--- apr_sms.h   2001/07/11 14:20:23     1.37
+++ apr_sms.h   2001/07/11 18:11:58
@@ -413,7 +413,7 @@
 #endif /* APR_DEBUG_TAG_SMS */
 
 #if SMS_ALLOC_STATS
-APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
+# APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
 #endif
 
 #ifdef __cplusplus        

Greg

Re: cvs commit: apr/include apr_pools.h apr_sms.h

Posted by David Reid <dr...@jetnet.co.uk>.
Ah yes, you're quite right and it shouldn't be there...that's the next
debugging type bit I have to add...

Apologies.  Thought I'd removed them all.

david
----- Original Message -----
From: "Greg Ames" <gr...@remulak.net>
To: <de...@apr.apache.org>
Sent: Wednesday, July 11, 2001 7:04 PM
Subject: Re: cvs commit: apr/include apr_pools.h apr_sms.h


> dreid@apache.org wrote:
> >
> > dreid       01/07/11 07:20:31
> >
> >   Modified:    .        configure.in
> >                memory/unix apr_sms.c sms_private.h
> >                include  apr_pools.h apr_sms.h
>
> Whoops! seems to have broken the build:
>
> /bin/sh /home/gregames/apache/httpd-2.0/srclib/apr/libtool --silent
> --mode=compile gcc  -g -O2 -Wall -Wmissing-prototypes
> -Wstrict-prototypes -Wmissing-declarations -pthread
> -DNO_DBM_REWRITEMAP    -DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500
> -D_BSD_SOURCE -D_SVID_SOURCE -DAP_DEBUG
> -DAP_HAVE_DESIGNATED_INITIALIZER   -I.
> -I/home/gregames/apache/httpd-2.0/os/unix
> -I/home/gregames/apache/httpd-2.0/server/mpm/prefork
> -I/home/gregames/apache/httpd-2.0/modules/http
> -I/home/gregames/apache/httpd-2.0/include
> -I/home/gregames/apache/httpd-2.0/srclib/apr/include
> -I/home/gregames/apache/httpd-2.0/srclib/apr-util/include -c exports.c
> && touch exports.lo
> exports.c:342: `apr_sms_dump_stats' undeclared here (not in a function)
> make[2]: *** [exports.lo] Error 1
> make[2]: Leaving directory `/home/gregames/apache/httpd-2.0/server'
>
> It's the following:
>
> >   Index: apr_sms.h
> >   ===================================================================
>
> >    APR_DECLARE(void) apr_sms_tag(apr_sms_t *sms, const char *tag);
> >    #endif /* APR_DEBUG_TAG_SMS */
> >   +
> >   +#if SMS_ALLOC_STATS
> >   +APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
> >   +#endif
> >
>
> make_export.awk doesn't seem to deal with this #if as one might hope.
> Commenting out the APR_DECLARE gets me building again:
>
> Index: srclib/apr/include/apr_sms.h
> ===================================================================
> RCS file: /cvs/apache/apr/include/apr_sms.h,v
> retrieving revision 1.37
> diff -u -d -b -r1.37 apr_sms.h
> --- apr_sms.h   2001/07/11 14:20:23     1.37
> +++ apr_sms.h   2001/07/11 18:11:58
> @@ -413,7 +413,7 @@
>  #endif /* APR_DEBUG_TAG_SMS */
>
>  #if SMS_ALLOC_STATS
> -APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
> +# APR_DECLARE(void) apr_sms_dump_stats(apr_sms_t *sms);
>  #endif
>
>  #ifdef __cplusplus
>
> Greg
>


Re: cvs commit: apr/include apr_pools.h apr_sms.h

Posted by Justin Erenkrantz <je...@ebuilt.com>.
I committed the proper fix to this a few hours ago
(SMS_ALLOC_STATS->APR_SMS_ALLOC_STATS).  

The sluggish list isn't helping things much.  -- justin

On Wed, Jul 11, 2001 at 02:04:38PM -0400, Greg Ames wrote:
> dreid@apache.org wrote:
> > 
> > dreid       01/07/11 07:20:31
> > 
> >   Modified:    .        configure.in
> >                memory/unix apr_sms.c sms_private.h
> >                include  apr_pools.h apr_sms.h
> 
> Whoops! seems to have broken the build: