[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16509: [Enhancement](storage) add a new hidden column __DORIS_VERSION_COL__ for unique key table

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #16509:
URL: https://github.com/apache/doris/pull/16509#discussion_r1099727822


##########
be/src/olap/tablet_schema.h:
##########
@@ -210,6 +210,8 @@ class TabletSchema {
     void set_delete_sign_idx(int32_t delete_sign_idx) { _delete_sign_idx = delete_sign_idx; }
     bool has_sequence_col() const { return _sequence_col_idx != -1; }
     int32_t sequence_col_idx() const { return _sequence_col_idx; }
+    void set_version_col_idx(int32_t version_col_idx) { _version_col_idx = version_col_idx; }
+    int32_t version_col_idx() { return _version_col_idx; }

Review Comment:
   warning: method 'version_col_idx' can be made const [readability-make-member-function-const]
   
   ```suggestion
       int32_t version_col_idx() const { return _version_col_idx; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org