[GitHub] [pulsar] merlimat commented on issue #4256: Use same activation dependency in pulsar-client-admin and pulsar-client

[GitBox <gi...@apache.org>]

merlimat commented on issue #4256: Use same activation dependency in pulsar-client-admin and pulsar-client
URL: https://github.com/apache/pulsar/pull/4256#issuecomment-492761771
 
 
   @kimcs There's a problem with the LICENSE file: 
   
   ```
   + src/check-binary-license ./distribution/server/target/apache-pulsar-2.4.0-SNAPSHOT-bin.tar.gz
   javax.activation-api-1.2.0.jar mentioned in LICENSE, but not bundled
   activation-1.0.2.jar mentioned in LICENSE, but not bundled
   
   It looks like there are issues with the LICENSE/NOTICE.
   ```
   
   We also need to update the LICENSE file at: https://github.com/apache/pulsar/blob/ac8e4e38e8d5b811ed871711117393553c9687f4/distribution/server/src/assemble/LICENSE.bin.txt#L515-L520
   
   with the new name and version of the dependency. 
   
   Also, probably we'll need to also update the LICENSE file for Presto as well: https://github.com/apache/pulsar/blob/master/pulsar-sql/presto-distribution/LICENSE#L502

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services