[GitHub] [cordova-ios] brodybits commented on a change in pull request #752: fix: replace variables in Podfile

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #752: fix: replace variables in Podfile
URL: https://github.com/apache/cordova-ios/pull/752#discussion_r359099005
 
 

 ##########
 File path: bin/templates/scripts/cordova/Api.js
 ##########
 @@ -406,10 +407,11 @@ Api.prototype.addPodSpecs = function (plugin, podSpecs, frameworkPods) {
         events.emit('warn', '"framework" tag with type "podspec" is deprecated and will be removed. Please use the "podspec" tag.');
         events.emit('verbose', 'Adding pods since the plugin contained <framework>(s) with type="podspec"');
         frameworkPods.forEach(function (obj) {
+            var spec = obj.spec.includes('$') ? installOptions.variables[obj.spec.replace('$', '')] : obj.spec;
 
 Review comment:
   This looks like repeated code. I wonder if we could factor this out somehow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org