You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/02/01 19:26:17 UTC

[PR] Exclude unnecessary ui build artifacts from wheel [airflow]

guan404ming opened a new pull request, #61335:
URL: https://github.com/apache/airflow/pull/61335

   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ## Related Issue
   
   closes #59821
   
   ## Why
   
   Production wheels ship 872 unnecessary frontend dev files (package.json, pnpm-lock.yaml, TypeScript source, configs, etc.) that bloat the wheel by ~1.5MB. Only the pre-built dist/ directories are needed at runtime.
   
   ## How
   
   Replace the narrow node_modules/-only excludes in the wheel target with ** globs that exclude everything under UI folder.
   The dist/ folders are preserved because hatch artifacts override exclude patterns.
   
   |                         | Before                               | After                    |
   |-------------------------|--------------------------------------|--------------------------|
   | Wheel size              | 5.6 MB                               | 4.1 MB                   |
   | File count              | 1,806                                | 935                      |
   | Excluded                | node_modules/, openapi.merged.json   | Everything except dist/  |
   | UI source code in wheel | Yes                                  | No                       |
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Exclude unnecessary ui build artifacts from wheel [airflow]

Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #61335:
URL: https://github.com/apache/airflow/pull/61335#issuecomment-3840575429

   cc: @bbovenzi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Exclude unnecessary ui build artifacts from wheel [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61335:
URL: https://github.com/apache/airflow/pull/61335#issuecomment-3842027344

   ### Backport successfully created: v3-1-test
   
   <table>
                   <tr>
                       <th>Status</th>
                       <th>Branch</th>
                       <th>Result</th>
                   </tr>
                   <tr>
                       <td>✅</td>
                       <td>v3-1-test</td>
                       <td><a href="https://github.com/apache/airflow/pull/61397"><img src="https://img.shields.io/badge/PR-61397-blue" alt="PR Link"></a></td>
                   </tr>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Exclude unnecessary ui build artifacts from wheel [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #61335:
URL: https://github.com/apache/airflow/pull/61335#issuecomment-3841911753

   Looks good to me. 
   
   I tested that only `dist` is available in the wheel distribution, all files - including sources - are present in `sdist`  and I installed airflow from the distributions prepared in main and it worked properly. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Exclude unnecessary ui build artifacts from wheel [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #61335:
URL: https://github.com/apache/airflow/pull/61335


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Exclude unnecessary ui build artifacts from wheel [airflow]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #61335:
URL: https://github.com/apache/airflow/pull/61335#issuecomment-3842090582

   > LGTM. Thanks. With Apache Airflow downloaded around 15 million times a month this will be a good improvement.
   
   Thanks for that. It would save world a lots time.
   
   > I tested that only dist is available in the wheel distribution, all files - including sources - are present in sdist and I installed airflow from the distributions prepared in main and it worked properly.
   
   Thanks. I also verified it works!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org