[GitHub] [ratis] szetszwo commented on a diff in pull request #692: RATIS-1635. Support listener in MiniRaftCluster

[GitBox <gi...@apache.org>]

szetszwo commented on code in PR #692:
URL: https://github.com/apache/ratis/pull/692#discussion_r927817025


##########
ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java:
##########
@@ -39,9 +39,9 @@ public class MiniRaftClusterWithGrpc extends MiniRaftCluster.RpcBase {
   public static final Factory<MiniRaftClusterWithGrpc> FACTORY
       = new Factory<MiniRaftClusterWithGrpc>() {
     @Override
-    public MiniRaftClusterWithGrpc newCluster(String[] ids, RaftProperties prop) {
+    public MiniRaftClusterWithGrpc newCluster(String[] ids, String[] ids1, RaftProperties prop) {

Review Comment:
   Rename all ids1 to listenerIds.



##########
ratis-server/src/test/java/org/apache/ratis/server/impl/MiniRaftCluster.java:
##########
@@ -410,11 +441,21 @@ public PeerChanges addNewPeers(int number, boolean startNewPeer)
 
   public PeerChanges addNewPeers(int number, boolean startNewPeer,
       boolean emptyPeer) throws IOException {
-    return addNewPeers(generateIds(number, servers.size()), startNewPeer, emptyPeer);
+    return addNewPeers(generateIds(number, servers.size()), startNewPeer, emptyPeer, false);
   }
 
   public PeerChanges addNewPeers(String[] ids, boolean startNewPeer,
       boolean emptyPeer) throws IOException {
+    return addNewPeers(ids, startNewPeer, emptyPeer, false);
+  }
+
+  public PeerChanges addNewPeers(int number, boolean startNewPeer,
+      boolean emptyPeer, boolean isListener) throws IOException {

Review Comment:
   Similar to other code, pass RaftPeerRole instead of isListener.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org