[GitHub] [incubator-nuttx] protobits commented on pull request #3704: Migrate build system to CMake

[GitBox <gi...@apache.org>]

protobits commented on pull request #3704:
URL: https://github.com/apache/incubator-nuttx/pull/3704#issuecomment-858596866


   > Separate branch is definitely a showstopper. I am willing to migrate my custom board to cmake, but if it is in separate branch I will stuck to this branch. When it will be in the master branch, more people will test it.
   > 
   > Let's think how it can be merged to master as soon as possible. Cmake may be incomplete. The main condition to merge to the master is that the make shouldn't be altered.
   > 
   > Let's start.
   > Choices can be returned to the top Kconfig
   > 
   > ```
   > +choice
   > +	prompt "Build Host Platform"
   > +	default HOST_LINUX
   > +
   >  config HOST_LINUX
   > -	bool
   > +	bool "Linux"
   >  	option env="HOST_LINUX"
   >  
   >  config HOST_MACOS
   > -	bool
   > +	bool "macOS"
   >  	option env="HOST_MACOS"
   >  
   >  config HOST_WINDOWS
   > -	bool
   > +	bool "Windows"
   >  	option env="HOST_WINDOWS"
   >  
   >  config HOST_OTHER
   > -	bool
   > +	bool "Other"
   >  	option env="HOST_OTHER"
   >  
   > +endchoice
   > ```
   > 
   > The drivers Kconfig can have defaults
   > 
   > ```
   > config DRIVERS_PLATFORM_DIR
   >         string
   >         option env="DRIVERS_PLATFORM_DIR"
   > 		default "drivers/platform"
   > 
   > source "$DRIVERS_PLATFORM_DIR/Kconfig"
   > ```
   > 
   > Now I can build stm32f4discovery with make and with cmake.
   
   You can't provide various defaults to the choice. In any case, sethost.sh could be adapted to supply the corresponding variable I believe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org