You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2025/03/20 13:19:28 UTC
(commons-jxpath) 04/08: Make the private JDOMNodePointer.id field final
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git
commit 7b9d9c3c5ae2176914962cfec8b1d838ed1d5dac
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Thu Mar 20 08:39:41 2025 -0400
Make the private JDOMNodePointer.id field final
---
src/changes/changes.xml | 1 +
.../org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java | 6 ++++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f1f4e9e..b655342 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -131,6 +131,7 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private DOMNodePointer.id field final.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private NullPointer.id field final.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private NullPointer.qname field final.</action>
+ <action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private JDOMNodePointer.id field final.</action>
<!-- ADD -->
<action issue="JXPATH-123" dev="mbenson" type="add">
XPath function "ends-with" is not implemented (although "starts-with" is).
diff --git a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
index 3e3d69d..f2d895c 100644
--- a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
+++ b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
@@ -224,8 +224,8 @@ public class JDOMNodePointer extends NodePointer {
/** Node, like a bean. */
private final Object node;
- /** ID. */
- private String id;
+ /** Optional ID, may be null. */
+ private final String id;
/** Local namespace resolver. */
private NamespaceResolver localNamespaceResolver;
@@ -239,6 +239,7 @@ public class JDOMNodePointer extends NodePointer {
public JDOMNodePointer(final NodePointer parent, final Object node) {
super(parent);
this.node = node;
+ this.id = null;
}
/**
@@ -250,6 +251,7 @@ public class JDOMNodePointer extends NodePointer {
public JDOMNodePointer(final Object node, final Locale locale) {
super(null, locale);
this.node = node;
+ this.id = null;
}
/**