You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xishuaidelin (via GitHub)" <gi...@apache.org> on 2024/01/22 02:44:39 UTC
[PR] E2E for minibatch join [flink]
xishuaidelin opened a new pull request, #24161:
URL: https://github.com/apache/flink/pull/24161
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table-planner] Supports mini-batch for streaming regular join [flink]
Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu closed pull request #24161: [FLINK-34222][table-planner] Supports mini-batch for streaming regular join
URL: https://github.com/apache/flink/pull/24161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1913822230
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1467258035
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala:
##########
@@ -112,6 +112,7 @@ class StreamPhysicalJoin(
getUpsertKeys(right, joinSpec.getRightKeys)
)
)
+ .itemIf("miniBatch", "true", JoinUtil.isMiniBatchEnabled(unwrapTableConfig(this)))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1467257676
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MinibatchUtil.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CoBundleTrigger;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CountBundleTrigger;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CountCoBundleTrigger;
+
+/** Utility class for mini-batch related config. */
+public class MinibatchUtil {
+
+ /**
+ * Check if MiniBatch is enabled.
+ *
+ * @param config config
+ * @return true if MiniBatch enabled else false.
+ */
+ public static boolean isMiniBatchEnabled(ReadableConfig config) {
+ return config.get(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED);
+ }
+
+ /**
+ * Creates a MiniBatch trigger depends on the config for one input.
+ *
+ * @param config config
+ * @return MiniBatch trigger
+ */
+ public static CountBundleTrigger<RowData> createMiniBatchTrigger(ReadableConfig config) {
+ long size = miniBatchSize(config);
+ return new CountBundleTrigger<>(size);
+ }
+
+ /**
+ * Creates a MiniBatch trigger depends on the config for two input.
+ *
+ * @param config config
+ * @return MiniBatch trigger
+ */
+ public static CoBundleTrigger<RowData, RowData> createCoMiniBatchTrigger(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1913631542
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1913572174
> @xishuaidelin The failure case is an known issue (https://issues.apache.org/jira/browse/FLINK-34206), you can rebase the latest master and rerun the tests.
@lincoln-lil Thanks for your kindly reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1911579714
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] E2E for minibatch join [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1903008823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc0d27ae8047710e53107d9fd9b50b8578c9ff25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc0d27ae8047710e53107d9fd9b50b8578c9ff25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc0d27ae8047710e53107d9fd9b50b8578c9ff25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1467198322
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala:
##########
@@ -112,6 +112,7 @@ class StreamPhysicalJoin(
getUpsertKeys(right, joinSpec.getRightKeys)
)
)
+ .itemIf("miniBatch", "true", JoinUtil.isMiniBatchEnabled(unwrapTableConfig(this)))
Review Comment:
```suggestion
.itemIf("miniBatch", "true", MinibatchUtil.isMiniBatchEnabled(unwrapTableConfig(this)))
```
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MinibatchUtil.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CoBundleTrigger;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CountBundleTrigger;
+import org.apache.flink.table.runtime.operators.bundle.trigger.CountCoBundleTrigger;
+
+/** Utility class for mini-batch related config. */
+public class MinibatchUtil {
+
+ /**
+ * Check if MiniBatch is enabled.
+ *
+ * @param config config
+ * @return true if MiniBatch enabled else false.
+ */
+ public static boolean isMiniBatchEnabled(ReadableConfig config) {
+ return config.get(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED);
+ }
+
+ /**
+ * Creates a MiniBatch trigger depends on the config for one input.
+ *
+ * @param config config
+ * @return MiniBatch trigger
+ */
+ public static CountBundleTrigger<RowData> createMiniBatchTrigger(ReadableConfig config) {
+ long size = miniBatchSize(config);
+ return new CountBundleTrigger<>(size);
+ }
+
+ /**
+ * Creates a MiniBatch trigger depends on the config for two input.
+ *
+ * @param config config
+ * @return MiniBatch trigger
+ */
+ public static CoBundleTrigger<RowData, RowData> createCoMiniBatchTrigger(
Review Comment:
createMiniBatchCoTrigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] E2E for minibatch join [flink]
Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1462830909
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -95,6 +105,18 @@ object JoinUtil {
}
}
+ /** Creates a MiniBatch trigger for join depends on the config. */
+ def createMiniBatchTrigger(config: ReadableConfig): CountCoBundleTrigger[RowData, RowData] = {
Review Comment:
We can reuse the `AggregateUtil#createMiniBatchTrigger` method. Moreover, I think we can extract a MinibatchUtil class, move minibatch related to utility method to this class.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -50,6 +52,14 @@ import scala.collection.JavaConversions._
/** Util for [[Join]]s. */
object JoinUtil {
+ /** Returns true if mini-batch for join is enabled. */
+ def isMiniBatchEnabled(config: ReadableConfig): Boolean = {
+ val enableMiniBatch = config.get(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED)
+ val miniBatchLatency =
Review Comment:
We can remove this check because `StreamCommonSubGraphBasedOptimizer#doOptimize` method had checked it, And we can remove this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1913183889
@xishuaidelin The failure case is an known issue (https://issues.apache.org/jira/browse/FLINK-34206), you can rebase the latest master and rerun the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1913571547
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1912079018
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] E2E for minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1466230805
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -95,6 +105,18 @@ object JoinUtil {
}
}
+ /** Creates a MiniBatch trigger for join depends on the config. */
+ def createMiniBatchTrigger(config: ReadableConfig): CountCoBundleTrigger[RowData, RowData] = {
Review Comment:
Yes, This would make the code more clear. I would finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]
Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on PR #24161:
URL: https://github.com/apache/flink/pull/24161#issuecomment-1911877304
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org