[jira] Commented: (NMAVEN-147) DotnetToolchain Improvement, plus dotnet toolchain manager

["Brett Porter (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/NMAVEN-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148949#action_148949 ] 

Brett Porter commented on NMAVEN-147:
-------------------------------------

ok, I found the reason for the manager not working (see the attached issue).

It makes sense to provide an alternate manager as you have done, though it would be good if it could reproduce less of the code from the original and delegate to it (particularly loading the toolchains file, for example).

we also need to make it possible to run the entire test suite with a given toolchain (previous tests only did so for IT0000 and it wasn't configurable)

I suggest here vendor should be much like nmaven.version, ie:
- individual tests can choose to only run for certain vendors/framework versions
- most projects (unless testing the absence of a toolchain) will provide the toolchains plugin and extension in a profile
- use nmaven.toolchain.vendor / nmaven.toolchain.version to choose which to use for the test. Default is to omit them. If both are omitted, the toolchains plugin will not be enabled (no profile given to the project)

> DotnetToolchain Improvement, plus dotnet toolchain manager
> ----------------------------------------------------------
>
>                 Key: NMAVEN-147
>                 URL: http://jira.codehaus.org/browse/NMAVEN-147
>             Project: NMaven
>          Issue Type: Improvement
>          Components: Toolchain Integration
>    Affects Versions: 0.16
>            Reporter: Leopoldo Agdeppa III
>             Fix For: 0.16
>
>         Attachments: ImprovedDotnetToolChain.patch, toolchains.xml
>
>
> # Patch for improved DotnetToolchain
> - the patch includes a working DotnetToochain,  DotnetToolchainManager and a DotnetTootchainFactory and other supporting files
> - in this imporoved dotnettoolchain creating a toolchain would be as easy as adding some toolchain entry in your ~/.m2/toolchains.xml
> Example:
> <toolchains>
>      <toolchain>
>         <type>dotnet</type>
>         <provides>
>             <frameworkVersion>2.0</frameworkVersion>
>             <vendorVersion>2.0.50727</vendorVersion>
>             <vendor>MICROSOFT</vendor>
>             <id>.NET Framework 2.0</id>
>         </provides>
>         <configuration>
>             <installRoot>C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727</installRoot>
>             <sdkInstallRoot>C:\Program Files\Microsoft Visual Studio 8\SDK\v2.0</sdkInstallRoot>
>         </configuration>
>     </toolchain>
> </toolchains>
> - the improved toolchain also satisfies the toolchain philosophy where in you can specifiy what type of toolchain you want to use in your plugin/configurations/toolchains
> - also included a sample toolchains.xml and a sample-xsd.zip project, (the project will indecate a build error, but the XSD Plugin is a success, you can see its executions in the logs)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira