You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Mike Drob (Jira)" <ji...@apache.org> on 2020/03/25 18:30:00 UTC
[jira] [Commented] (SOLR-14322)
AbstractFullDistribZkTestBase.waitForThingsToLevelOut is very inconsistent
[ https://issues.apache.org/jira/browse/SOLR-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066958#comment-17066958 ]
Mike Drob commented on SOLR-14322:
----------------------------------
[~hossman] - I tagged you for a review on the PR since you've worked on this class before, if you wouldn't mind taking a look. Most of the change is pretty straightforward but I would appreciate an extra set of eyes on it.
> AbstractFullDistribZkTestBase.waitForThingsToLevelOut is very inconsistent
> --------------------------------------------------------------------------
>
> Key: SOLR-14322
> URL: https://issues.apache.org/jira/browse/SOLR-14322
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are many strange things going on with this method -
> 1. It accepts a value in seconds, but many callers pass millis
> 2. The method will only retry on the last shard being inconsistent, not any other shard
> 3. Catching Throwable is dubious.
> 4. There's a conditional wait mixed with an unconditional sleep. (this might be ok?)
> 5. There's a bunch of System.out and System.err
> 6. If we never get to the "level out state" we still simply return instead of somehow indicating the error condition
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org