You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/08/10 15:50:33 UTC

Review Request 37295: YARN NodeManager Health alert fails when kinit path is customized

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37295/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-12689
    https://issues.apache.org/jira/browse/AMBARI-12689


Repository: ambari


Description
-------

The Yarn NodeManager Health alert fails when kinit path is customized. This is due to a failure to pass the kinit search paths appropriately:

{code:title=common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py:148}
      url_response, error_msg, time_millis  = curl_krb_request(env.tmp_dir, kerberos_keytab, kerberos_principal,
        query, "nm_health_alert", None, False, "NodeManager Health", smokeuser,
        connection_timeout=curl_connection_timeout)
{code}

Note the 6th parameter is {{None}} when it should contain the relevant search paths.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py c1e0b54 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py a076825 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py 05b6a2a 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanagers_summary.py 845b616 

Diff: https://reviews.apache.org/r/37295/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 37295: YARN NodeManager Health alert fails when kinit path is customized

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37295/#review94737
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Авг. 10, 2015, 1:50 п.п., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37295/
> -----------------------------------------------------------
> 
> (Updated Авг. 10, 2015, 1:50 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-12689
>     https://issues.apache.org/jira/browse/AMBARI-12689
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Yarn NodeManager Health alert fails when kinit path is customized. This is due to a failure to pass the kinit search paths appropriately:
> 
> {code:title=common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py:148}
>       url_response, error_msg, time_millis  = curl_krb_request(env.tmp_dir, kerberos_keytab, kerberos_principal,
>         query, "nm_health_alert", None, False, "NodeManager Health", smokeuser,
>         connection_timeout=curl_connection_timeout)
> {code}
> 
> Note the 6th parameter is {{None}} when it should contain the relevant search paths.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py c1e0b54 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py a076825 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py 05b6a2a 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanagers_summary.py 845b616 
> 
> Diff: https://reviews.apache.org/r/37295/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>