You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/02 07:39:44 UTC
[GitHub] [skywalking] wankai123 opened a new issue, #10076: [Feature] Support listeners for the `RemoteClients` change.
wankai123 opened a new issue, #10076:
URL: https://github.com/apache/skywalking/issues/10076
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In the cluster mode, OAP instances send metrics to each other according to the `remote-hash code` to do L2 aggregation and alarm calculations for balancing​. Some of the calculations leverage the previously received metrics in the memory cache and incoming metrics. So when the OAP cluster scales, the metrics might lose their cache and impact the calculations.
To avoid this situation, I think we should support listeners for the `RemoteClients` change, then the stream workers can be notified and reload previous metrics from storage for calculation.
### Use case
1. Provide listeners' interface for notification and a registration mechanism.
2. When the `RemoteClients` changes, notice all listeners.
### Related issues
https://github.com/apache/skywalking/issues/10051
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1334905358
Let's see how @fgksgf would do. I think we need more work after this mechanism is ready.
Is there an ETA for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1334919238
#10051 doesn't rely on this as a hard requirement. Alerting enhancement requires this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1334933362
I think #9814 is not exactly the same. #9814 is trying to fix the delay between the OAP fetched `RemoteClients` and the real instance status. But this issue wants to resolve the other OAP module doesn't know the `RemoteClients` is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 closed issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
wankai123 closed issue #10076: [Feature] Support listeners for the `RemoteClients` change.
URL: https://github.com/apache/skywalking/issues/10076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1334914319
> Let's see how @fgksgf would do. I think we need more work after this mechanism is ready.
> Is there an ETA for review?
Before https://github.com/apache/skywalking/issues/10051 this issue is a "nice to have" enhancement so we don't set an ETA, but if it impacts the metrics in https://github.com/apache/skywalking/issues/10051, we could prioritize this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1334900516
This is duplicate of https://github.com/apache/skywalking/issues/9814 and I think @fgksgf is already working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1335376295
> I think #9814 is not exactly the same. #9814 is trying to fix the delay between the OAP fetched `RemoteClients` and the real instance status. But this issue wants to resolve the other OAP module services doesn't know the `RemoteClients` is changed.
If you read carefully they are exactly the same essentially. 9814 is to make the coordinator module know remote clients are changed. This can be shared to other modules and let them know the remote clients changed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10076: [Feature] Support listeners for the `RemoteClients` change.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10076:
URL: https://github.com/apache/skywalking/issues/10076#issuecomment-1336126263
@fgksgf @wankai123 @kezhenxu94 Please ref to https://github.com/apache/skywalking/pull/10083, when we build a notification callback mechanism, especially for cluster status, we could build this callback in the core module through new **ServerStatusService**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org