You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/02 09:15:16 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
lordcheng10 opened a new pull request, #17910:
URL: https://github.com/apache/pulsar/pull/17910
### Motivation
When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect.
When the following conditions are met, the compressedStr variable is assigned the empty string, but should be assigned the value "Compressed"
1. isBatchMessagingEnabled() return true;
2.msgMetadata.hasDeliverAtTime() return true;
3. compressedSize > ClientCnx.getMaxMessageSize() is true
4.conf.getCompressionType() != CompressionType.NONE is true;
https://github.com/apache/pulsar/blob/9ff9703d740eb8151b8cf2eb1e7faf074e9cf3c7/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L454-L473
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272264181
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1270362683
@codelipenghui @JipeiWang @Jason918 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1269246313
> LGTM. Please run CI from your own fork first, for details: https://pulsar.apache.org/contributing/#run-ci-from-fork
CI passed.
@AnonHxy PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272313335
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272216533
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272426813
@HQebupt PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1269307731
> > LGTM. Please run CI from your own fork first, for details: https://pulsar.apache.org/contributing/#run-ci-from-fork
>
> CI passed: [lordcheng10#23](https://github.com/lordcheng10/pulsar/pull/23) @AnonHxy PTAL,thanks!
LGTM. BTW, we just need put the owned fork link to the describe document :), I have updated it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272425278
@codelipenghui @Technoboy- PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272327967
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272238076
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272196489
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272272849
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1264894243
LGTM. Please run CI from your own fork first, for details: https://pulsar.apache.org/contributing/#run-ci-from-fork
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272199931
@aloyszhang PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1265090204
> LGTM. Please run CI from your own fork first, for details: https://pulsar.apache.org/contributing/#run-ci-from-fork
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272486714
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang merged pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
aloyszhang merged PR #17910:
URL: https://github.com/apache/pulsar/pull/17910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272224510
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272251369
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272301962
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17910:
URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1270360970
> > > LGTM. Please run CI from your own fork first, for details: https://pulsar.apache.org/contributing/#run-ci-from-fork
> >
> >
> > CI passed: [lordcheng10#23](https://github.com/lordcheng10/pulsar/pull/23) @AnonHxy PTAL,thanks!
>
> LGTM. BTW, we just need put the owned fork link to the describe document :), I have updated it
OK, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org