[GitHub] [zookeeper] eolivelli commented on a change in pull request #865: zoo_sample.cfg: enable autopurge and change dataDir

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #865: zoo_sample.cfg: enable autopurge and change dataDir 
URL: https://github.com/apache/zookeeper/pull/865#discussion_r268164779
 
 

 ##########
 File path: conf/zoo_sample.cfg
 ##########
 @@ -1,28 +1,29 @@
 # The number of milliseconds of each tick
 tickTime=2000
-# The number of ticks that the initial 
+# The number of ticks that the initial
 # synchronization phase can take
 initLimit=10
-# The number of ticks that can pass between 
+# The number of ticks that can pass between
 # sending a request and getting an acknowledgement
 syncLimit=5
 # the directory where the snapshot is stored.
-# do not use /tmp for storage, /tmp here is just 
-# example sakes.
-dataDir=/tmp/zookeeper
+# do not use /tmp for storage!!!.
+dataDir=/var/lib/zookeeper/data
 
 Review comment:
   I am not sure this is so safe.
   
   This is just an example file and it is only for dev/testing purpose.
   
   Therefore it is not sure that an user/developer  is able to write into that directory

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services