You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by maoling <gi...@git.apache.org> on 2017/08/25 01:07:48 UTC
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/348
ZOOKEEPER-2319:UnresolvedAddressException cause the QuorumCnxManager.Listener exit
more details in [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-2319)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-2319
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 5eb38e038fa555d471ec3ca7fb4a42e5df66263d
Author: maoling <ma...@sina.com>
Date: 2017-08-25T01:04:15Z
ZOOKEEPER-2319:UnresolvedAddressException cause the QuorumCnxManager.Listener exit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/348#discussion_r135342245
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -653,6 +653,9 @@ public void run() {
+ "see ZOOKEEPER-2836");
}
}
+ } catch (UnresolvedAddressException e) {
+ LOG.warn("Listener thread cannot open channel to " + self.getId()
--- End diff --
I think we may want to consider making this an "error".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/348#discussion_r135342442
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -621,7 +621,7 @@ public Listener() {
@Override
public void run() {
int numRetries = 0;
- InetSocketAddress addr;
+ InetSocketAddress addr = null;
--- End diff --
why is this needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/348#discussion_r136663144
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -621,7 +621,7 @@ public Listener() {
@Override
public void run() {
int numRetries = 0;
- InetSocketAddress addr;
+ InetSocketAddress addr = null;
--- End diff --
@maoling I think a test case would be great because catching that exception does "change behavior".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
Posted by maoling <gi...@git.apache.org>.
Github user maoling closed the pull request at:
https://github.com/apache/zookeeper/pull/348
---
[GitHub] zookeeper pull request #348: ZOOKEEPER-2319:UnresolvedAddressException cause...
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/348#discussion_r135400760
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -621,7 +621,7 @@ public Listener() {
@Override
public void run() {
int numRetries = 0;
- InetSocketAddress addr;
+ InetSocketAddress addr = null;
--- End diff --
for logging the **addr** in LINE_657
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #348: ZOOKEEPER-2319:UnresolvedAddressException cause the Qu...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/348
@maoling please see my comments on the JIRA, I think this can be closed.
---