You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/10/31 20:50:50 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7164: Pin node version in dev ciab TP/TPv2
shamrickus opened a new pull request, #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Currently the TP/TPv2 dev containers have issues starting due to node/npm versioning. `node:alpine` uses the latest node which currently is v19, many of our dependencies don't support this version causing the install to fail. This PR pins the node to version 14. Node 14 is in maintenance mode as of [two weeks ago](https://github.com/nodejs/release#release-schedule), so whenever angular in tpv2 is updated these can be bumped to 16.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- CDN in a Box (dev)
## What is the best way to verify this PR?
Verify the TP/TPv2 dev containers are able to startup. The containers should also not complain about node version mismatch.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298972615
No it's not displaying anything, at all. Like I would show you the logs but they're literally empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299300701
Well, I don't know what exactly the issue was, but after 7 hours there was still nothing in the logs. So I purged my docker cache, removed most directories from my local repo and restored from the tip of this branch, then tried again. And it works now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299046154
> When I run the dev env on this branch, Traffic Router and tpv2 fail to start.
Both TR and TPv2 start as expected for me on Linux on #7164's branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
shamrickus commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299019963
> No it's not displaying anything, at all. Like I would show you the logs but they're literally empty.
Assuming the container is still running, I stand by what I said. It took 10 minutes for it to display anything for me this morning.
Regardless I've tested on two separate machines using OSX and linux and they both work flawlessly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298672040
When I run the dev env on this branch, Traffic Router and tpv2 fail to start.
<details><summary>Traffic Router Logs</summary>
```
trafficrouter_1 | [INFO] Scanning for projects...
trafficrouter_1 | [INFO] ------------------------------------------------------------------------
trafficrouter_1 | [INFO] Reactor Build Order:
trafficrouter_1 | [INFO]
trafficrouter_1 | [INFO] traffic_router [pom]
trafficrouter_1 | [INFO] traffic_router_shared [jar]
trafficrouter_1 | [INFO] traffic_router_connector [jar]
trafficrouter_1 | [INFO] traffic_router_config [jar]
trafficrouter_1 | [INFO] traffic_router_geolocation [jar]
trafficrouter_1 | [INFO] ROOT [war]
trafficrouter_1 | [INFO]
trafficrouter_1 | [INFO] ------< org.apache.traffic_control.traffic_router:traffic_router >------
trafficrouter_1 | [INFO] Building traffic_router 7.1.0 [1/6]
trafficrouter_1 | [INFO] --------------------------------[ pom ]---------------------------------
trafficrouter_1 | [INFO]
trafficrouter_1 | [INFO] --< org.apache.traffic_control.traffic_router:traffic_router_shared >---
trafficrouter_1 | [INFO] Building traffic_router_shared 7.1.0 [2/6]
trafficrouter_1 | [INFO] --------------------------------[ jar ]---------------------------------
trafficrouter_1 | Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom
trafficrouter_1 | [INFO] ------------------------------------------------------------------------
trafficrouter_1 | [INFO] Reactor Summary for traffic_router 7.1.0:
trafficrouter_1 | [INFO]
trafficrouter_1 | [INFO] traffic_router ..................................... SUCCESS [ 0.003 s]
trafficrouter_1 | [INFO] traffic_router_shared .............................. FAILURE [ 5.638 s]
trafficrouter_1 | [INFO] traffic_router_connector ........................... SKIPPED
trafficrouter_1 | [INFO] traffic_router_config .............................. SKIPPED
trafficrouter_1 | [INFO] traffic_router_geolocation ......................... SKIPPED
trafficrouter_1 | [INFO] ROOT ............................................... SKIPPED
trafficrouter_1 | [INFO] ------------------------------------------------------------------------
trafficrouter_1 | [INFO] BUILD FAILURE
trafficrouter_1 | [INFO] ------------------------------------------------------------------------
trafficrouter_1 | [INFO] Total time: 5.883 s
trafficrouter_1 | [INFO] Finished at: 2022-11-01T15:06:13Z
trafficrouter_1 | [INFO] ------------------------------------------------------------------------
trafficrouter_1 | [ERROR] Plugin org.apache.maven.plugins:maven-resources-plugin:2.6 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.6: Could not transfer artifact org.apache.maven.plugins:maven-resources-plugin:pom:2.6 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom: Unknown host repo.maven.apache.org: Try again -> [Help 1]
trafficrouter_1 | [ERROR]
trafficrouter_1 | [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
trafficrouter_1 | [ERROR] Re-run Maven using the -X switch to enable full debug logging.
trafficrouter_1 | [ERROR]
trafficrouter_1 | [ERROR] For more information about the errors and possible solutions, please read the following articles:
trafficrouter_1 | [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
```
</detalis>
TPv2 logs are just... empty. The container is running, but it never does anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7164: Pin node version in dev ciab TP/TPv2
Posted by GitBox <gi...@apache.org>.
shamrickus commented on PR #7164:
URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298691974
> TPv2 logs are just... empty. The container is running, but it never does anything.
If it's not displaying anything then `npm ci/install` is probably still doing it's thing. I have no idea why but it _can_ take a lot longer to do that in the container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org