You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:47:27 UTC

[GitHub] [arrow-rs] liukun4515 commented on pull request #2428: refactor: refine validation for decimal128 array

liukun4515 commented on PR #2428:
URL: https://github.com/apache/arrow-rs/pull/2428#issuecomment-1212978096

   Benchmark result:
   before this refactor:
   ```
   validate_decimal128_array 20000
                           time:   [56.566 us 56.867 us 57.195 us]
                           change: [-0.7933% -0.1263% +0.5894%] (p = 0.72 > 0.05)
                           No change in performance detected.
   Found 7 outliers among 100 measurements (7.00%)
     6 (6.00%) high mild
     1 (1.00%) high severe
   ```
   
   After this refactor:
   
   ```
   validate_decimal128_array 20000
                           time:   [34.534 us 34.711 us 34.895 us]
                           change: [-39.461% -39.030% -38.571%] (p = 0.00 < 0.05)
                           Performance has improved.
   ```
   
   The performance improves about 40%


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org