You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2019/02/09 07:27:59 UTC
[GitHub] thefourtheye opened a new pull request #87: clear response buffer
with unsupported extension
thefourtheye opened a new pull request #87: clear response buffer with unsupported extension
URL: https://github.com/apache/mina-sshd/pull/87
As it is, if a client requests to use an extension which is not
supported by the server, the server is supposed to send
`SSH_FX_OP_UNSUPPORTED`. It does send that, but it doesn't clear the
`Buffer` object before sending the response. So, all the clients who
are requesting an unsupported extension are impacted with invalid
bytestream of response data and the channel becomes unusable.
This patch simply clears the buffer with `prepareReply` function before
sending the response.
---
cc @The-Yoda @sramki
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services