You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2021/08/25 18:35:43 UTC
[GitHub] [tez] jteagles opened a new pull request #147: TEZ-4330. Import external tez component em-tgraph
jteagles opened a new pull request #147:
URL: https://github.com/apache/tez/pull/147
Co-authored-by: Sreenath Somarajapuram <sr...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on pull request #147:
URL: https://github.com/apache/tez/pull/147#issuecomment-906623454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 42s | master passed |
| +1 :green_heart: | javadoc | 0m 44s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 21s | the patch passed |
| +1 :green_heart: | jshint | 52m 35s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 21s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 52s | tez-ui in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 72m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/147 |
| Optional Tests | dupname asflicense javac javadoc unit jshint |
| uname | Linux 974ec6de6131 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 0ccf440e6 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/testReport/ |
| Max. process+thread count | 93 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] sreenaths commented on a change in pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
sreenaths commented on a change in pull request #147:
URL: https://github.com/apache/tez/pull/147#discussion_r696464476
##########
File path: tez-ui/src/main/webapp/app/controllers/dag/swimlane.js
##########
@@ -19,10 +19,10 @@
import Ember from 'ember';
import MultiTableController from '../multi-table';
-import ColumnDefinition from 'em-table/utils/column-definition';
Review comment:
Yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on pull request #147:
URL: https://github.com/apache/tez/pull/147#issuecomment-906739553
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 54s | master passed |
| +1 :green_heart: | javadoc | 0m 45s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 31s | the patch passed |
| +1 :green_heart: | jshint | 56m 18s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 18s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 2s | tez-ui in the patch passed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 76m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/147 |
| Optional Tests | dupname asflicense javac javadoc unit jshint |
| uname | Linux 2381fcf8a5f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 0ccf440e6 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/testReport/ |
| Max. process+thread count | 92 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #147:
URL: https://github.com/apache/tez/pull/147#issuecomment-946521757
my previous comment was addressed, other than that this is mostly a copy from another repo (I mean don't have to read it line-by-line), precommit is green, so it's a +1 from my side
please let us know @sreenaths if you found any problems, otherwise I'll merge this and maybe go for mock-ats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on a change in pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
jteagles commented on a change in pull request #147:
URL: https://github.com/apache/tez/pull/147#discussion_r696808442
##########
File path: tez-ui/src/main/webapp/app/controllers/dag/swimlane.js
##########
@@ -19,10 +19,10 @@
import Ember from 'ember';
import MultiTableController from '../multi-table';
-import ColumnDefinition from 'em-table/utils/column-definition';
Review comment:
@sreenaths / @abstractdog updated to fix import. should be ready for review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on pull request #147:
URL: https://github.com/apache/tez/pull/147#issuecomment-905787813
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 45s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | jshint | 0m 6s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 3s | The patch does not generate ASF License warnings. |
| | | 14m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/147 |
| Optional Tests | dupname asflicense jshint |
| uname | Linux a3c2f5e528b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / e2c4ee084 |
| Max. process+thread count | 51 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on pull request #147:
URL: https://github.com/apache/tez/pull/147#issuecomment-906574470
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | jshint | 0m 6s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 2m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/147 |
| Optional Tests | dupname asflicense jshint |
| uname | Linux 665a9c424f87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 0ccf440e6 |
| Max. process+thread count | 51 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on a change in pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
jteagles commented on a change in pull request #147:
URL: https://github.com/apache/tez/pull/147#discussion_r696672937
##########
File path: tez-ui/src/main/webapp/app/controllers/dag/swimlane.js
##########
@@ -19,10 +19,10 @@
import Ember from 'ember';
import MultiTableController from '../multi-table';
-import ColumnDefinition from 'em-table/utils/column-definition';
Review comment:
Thanks. This change was in em-table PR as well. I'm glad you caught this accidental import. I'll merge em-table and then audit the list of imports to make sure we are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on a change in pull request #147: TEZ-4330. Import external tez component em-tgraph
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #147:
URL: https://github.com/apache/tez/pull/147#discussion_r696412673
##########
File path: tez-ui/src/main/webapp/app/controllers/dag/swimlane.js
##########
@@ -19,10 +19,10 @@
import Ember from 'ember';
import MultiTableController from '../multi-table';
-import ColumnDefinition from 'em-table/utils/column-definition';
Review comment:
shouldn't this be part of em-table import, which is TEZ-4329?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org