You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2017/12/06 09:03:19 UTC
[GitHub] activemq-artemis pull request #1689: ARTEMIS-1540 Missing management annotat...
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1689
ARTEMIS-1540 Missing management annotations
Some of the management operations are not properly annotated.
Also need to add an Operation to list divert names.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis lmaster_fix_jon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1689
----
commit 0c90d7830f82542ad6149fb37e787e746e48df64
Author: Howard Gao <ho...@gmail.com>
Date: 2017-12-06T05:00:42Z
ARTEMIS-1540 Missing management annotations
Some of the management operations are not properly annotated.
Also need to add an Operation to list divert names.
----
---
[GitHub] activemq-artemis issue #1689: ARTEMIS-1540 Missing management annotations
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1689
+1 LGTM
---
[GitHub] activemq-artemis issue #1689: ARTEMIS-1540 Missing management annotations
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1689
Looks good. I can’t merge it now. But it will do as soon as I can. (Or anyone can do it)
---
[GitHub] activemq-artemis issue #1689: ARTEMIS-1540 Missing management annotations
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1689
Thanks @gaohoward merged.
---
[GitHub] activemq-artemis pull request #1689: ARTEMIS-1540 Missing management annotat...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1689#discussion_r155675756
--- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java ---
@@ -631,7 +631,9 @@ default Message setAnnotation(SimpleString key, Object value) {
default Map<String, Object> toPropertyMap() {
Map map = new HashMap<>();
for (SimpleString name : getPropertyNames()) {
- map.put(name.toString(), getObjectProperty(name.toString()));
+ //some property is SimpleString, which is not available for management console
+ Object value = getObjectProperty(name.toString());
+ map.put(name.toString(), value == null ? null : value.toString());
--- End diff --
nice catch.
---
[GitHub] activemq-artemis issue #1689: ARTEMIS-1540 Missing management annotations
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1689
thanks guys
---
[GitHub] activemq-artemis pull request #1689: ARTEMIS-1540 Missing management annotat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1689
---