[jira] [Commented] (QPID-3207) AMQSession.java close() does not close the consumers with the correct arguments

["Rob Godfrey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312891#comment-14312891 ] 

Rob Godfrey commented on QPID-3207:
-----------------------------------

There's no reason why we would need to send explicit closes for the consumers, it should be enough on the server side to receive the session close, and obviously issues occur if this the proposed code change is made.

Given there has been no work done on this JIRA for almost 4 years, I propose we close this JIRA as a "not an issue"

> AMQSession.java close() does not close the consumers with the correct arguments
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3207
>                 URL: https://issues.apache.org/jira/browse/QPID-3207
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.10
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: Future
>
>
> When the AMQSession.java close() is invoked it will in turn call the "private void closeConsumers(Throwable error) throws JMSException"  method.
> In this method if the error is null then the consumer.close method is called with "sendClose=false".
> I wonder if this is the correct setting. I suspect the intended value is "true".
> The boolean value is used in determining if we should send a message-cancel or not.
> I am not sure why we are not going to send a message cancel in this case, as we haven't encountered a session error and the session is active.
> Note the AMQSession.java closes the session only after the consumers and producers are closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org