You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2012/05/11 20:19:49 UTC

Warning! In the next few hours, I will be committing findByPrimaryKey->findOne changes

As I have discussed, I will be committing a series of separate
commits, that change findByPrimaryKey calls into findOne.  I have run
the test cases on these changes, and everything compiles.  However,
ofbiz does *not* have 100% coverage, no where close.  Some of the
changes are inside groovy/ftl files, which have little coverage by
default.

There may be some breakage, I can't say with 100% certainty.  Each
changed line was *not* done by a script, but by me grepping for all
files that contain the pattern, then manually inspecting each line and
fixing it.  I've also scanned each diff just before committing, to
verify that I got the correct true/false value for the caching flag,
and that any glaring syntax errors don't stand out(in files that I
can't compile-test, anyways).

My plan is to backport this change to 12.04.  But, it needs to sit in
trunk for a bit first.  I also have commits for findByAnd(Cache),
getRelatedOne(Cache), and getRelatedDummyPK, but those will come
later.  They are not part of this commit.

I've split the 800kB commit into several smaller ones.  One for all of
framework, then one each for every component in applications and
specialpurpose, then finally the actual @Deprecated tags.  This should
make it easier to bisect the code later if any problems occur.  It
should also make it easier for others to validate.