[jira] Commented: (MJAR-53) In pom with packaging "war" the generated jar will be installed in repo instead of the war

["Dennis Lundberg (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MJAR-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116197 ] 

Dennis Lundberg commented on MJAR-53:
-------------------------------------

Martin, I'm not sure I understand what it is you want the jar-plugin to do for you.

The way I see it, the jar-plugin shouldn't handle war files at all. That is the responsibility of another plugin.

What should the jar-plugin do for projects that have packaging!=jar ?
Should it simply check that the project has packaging==jar before doing anything?


> In pom with packaging "war" the generated jar will be installed in repo instead of the war
> ------------------------------------------------------------------------------------------
>
>                 Key: MJAR-53
>                 URL: http://jira.codehaus.org/browse/MJAR-53
>             Project: Maven 2.x Jar Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>         Environment: WinXp
>            Reporter: Martin Zeltner
>            Priority: Blocker
>         Attachments: patch_jar-maven2-allow-override-project-artifact.txt
>
>
> In pom with packaging "war" the generated jar will be installed in repo instead of the war! To solve this just do not set the file of project's artifact if it is already set and attach the jar artifact to the project's artifact. Here's the patch:
> {code}
> Index: D:/Programs/Maven2/maven/plugins/maven-jar-plugin/src/main/java/org/apache/maven/plugin/jar/AbstractJarMojo.java
> ===================================================================
> --- D:/Programs/Maven2/maven/plugins/maven-jar-plugin/src/main/java/org/apache/maven/plugin/jar/AbstractJarMojo.java    (revision 425019)
> +++ D:/Programs/Maven2/maven/plugins/maven-jar-plugin/src/main/java/org/apache/maven/plugin/jar/AbstractJarMojo.java    (working copy)
> @@ -166,7 +166,8 @@
>          File jarFile = createArchive();
>  
>          String classifier = getClassifier();
> -        if ( classifier != null )
> +        if ( classifier != null 
> +            || getProject().getArtifact().getFile() != null )
>          {
>              projectHelper.attachArtifact( getProject(), "jar", classifier, jarFile );
>          }
> {code}
> I could also imagine to use a boolean property "allowOverrideProjectArtifact" which is true by default (current case).
> Cheers,
> Martin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira