You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/01/19 06:47:30 UTC
[Bug 58888] New: HTTP(S) Test Script Recorder (ProxyControl) does
add TestElement's returned by SamplerCreator createChildren ()
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Bug ID: 58888
Summary: HTTP(S) Test Script Recorder (ProxyControl) does add
TestElement's returned by SamplerCreator
createChildren ()
Product: JMeter
Version: 2.13
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: kostas@methodosit.com.cy
Created attachment 33464
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33464&action=edit
Patch for ProxyControl
Hi,
I am creating an addon which extends DefaultSamplerCreator and automates the
addition of some assertions on the recorded requests. It looks that
createChildren() method of SamplerCreator is the natural place for such a
function.
I found however that ProxyControl only adds HeaderManager as children. The
attached patch allows the ProxyControl to add ResponseAssertion, ResultSaver,
and SizeAssertion.
A more general way to add any assertion probably exists. If someone can point
me to right direction, I will take a look.
Regards
kostas
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Jun 12 13:44:17 2016
New Revision: 1748004
URL: http://svn.apache.org/viewvc?rev=1748004&view=rev
Log:
Bug 58888 - HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Bugzilla Id: 58888
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Michael Chirlin <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|2.13 |3.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
Minor refactorings.
Date: Sun Jun 12 14:14:37 2016
New Revision: 1748012
URL: http://svn.apache.org/viewvc?rev=1748012&view=rev
Log:
Syntactic sugar. First check for null, then use 'new' for loop.
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
Date: Sun Jun 12 14:50:47 2016
New Revision: 1748016
URL: http://svn.apache.org/viewvc?rev=1748016&view=rev
Log:
Rename private methods to shorter names and add refactor testing for addable
TestElements.
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
Hardware|PC |All
OS|Linux |All
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Michael Chirlin <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |michael.chirlin@gmail.com
Severity|normal |blocker
--- Comment #1 from Michael Chirlin <mi...@gmail.com> ---
The change should not specify the node type:
for (int i = 0; subConfigs != null && i < subConfigs.length; i++) {
if (subConfigs[i] instanceof HeaderManager) {
subConfigs[i].setProperty(TestElement.GUI_CLASS, HEADER_PANEL);
}
treeModel.addComponent(subConfigs[i], newNode);
}
Basically, the treeModel.addComponent needs to be pulled out of the if
statement. As long as you specify the TestElement.GUI_CLASS in the
createChildren method, you don't need to do it again here.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
kostas@methodosit.com.cy changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|HTTP(S) Test Script |HTTP(S) Test Script
|Recorder (ProxyControl) |Recorder (ProxyControl)
|does add TestElement's |does not add TestElement's
|returned by SamplerCreator |returned by SamplerCreator
|createChildren () |createChildren ()
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 58888] HTTP(S) Test Script Recorder (ProxyControl) does not add
TestElement's returned by SamplerCreator createChildren ()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58888
Michael Chirlin <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|blocker |normal
--
You are receiving this mail because:
You are the assignee for the bug.