You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/11 05:34:51 UTC
Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed
time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 3:34 a.m.)
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
Diff: https://reviews.apache.org/r/24537/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed
time.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/#review50253
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/metrics/timer.hpp
<https://reviews.apache.org/r/24537/#comment87933>
maybe also return the time from this too for symmetry?
- Dominic Hamon
On Aug. 10, 2014, 8:34 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24537/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 8:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
>
> Diff: https://reviews.apache.org/r/24537/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24537: Updated metrics::Timer::stop to return
elapsed time.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/#review56180
-----------------------------------------------------------
Hey Ben, I've committed this for you as I would like to leverage this in r/26535.
- Ben Mahler
On Sept. 29, 2014, 12:24 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24537/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 12:24 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
>
> Diff: https://reviews.apache.org/r/24537/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24537: Updated metrics::Timer::stop to return
elapsed time.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/#review54821
-----------------------------------------------------------
Could you add to the tests to cover this change in API?
- Dominic Hamon
On Sept. 29, 2014, 5:24 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24537/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 5:24 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
>
> Diff: https://reviews.apache.org/r/24537/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24537: Updated metrics::Timer::stop to return
elapsed time.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/
-----------------------------------------------------------
(Updated Sept. 29, 2014, 12:24 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
Diff: https://reviews.apache.org/r/24537/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed
time.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/#review50251
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/metrics/timer.hpp
<https://reviews.apache.org/r/24537/#comment87928>
Can we now remove this variable in favor of 'push(t.value())' below?
- Ben Mahler
On Aug. 11, 2014, 3:34 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24537/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 3:34 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f
>
> Diff: https://reviews.apache.org/r/24537/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>