You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/04/06 22:57:33 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6748: fixing license headers and plugin checks
fx19880617 opened a new pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748
## Description
- Fix Apache license
- Fix rat check
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #6748: fixing license headers and plugin checks
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #6748: fixing license headers and plugin checks
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748#issuecomment-814537759
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=h1) Report
> Merging [#6748](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=desc) (b8346cf) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4aef4c48f5f459aefe32732db17598ef490e2dde?el=desc) (4aef4c4) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6748 +/- ##
============================================
- Coverage 43.06% 42.94% -0.12%
Complexity 7 7
============================================
Files 1407 1407
Lines 68459 68459
Branches 9896 9896
============================================
- Hits 29482 29400 -82
- Misses 36503 36600 +97
+ Partials 2474 2459 -15
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `42.94% <ø> (-0.12%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/pinot/core/operator/docidsets/OrDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JEb2NJZFNldC5qYXZh) | `56.81% <0.00%> (-29.55%)` | `0.00% <0.00%> (ø%)` | |
| [...ion/groupby/AggregationGroupByTrimmingService.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0FnZ3JlZ2F0aW9uR3JvdXBCeVRyaW1taW5nU2VydmljZS5qYXZh) | `66.66% <0.00%> (-27.54%)` | `0.00% <0.00%> (ø%)` | |
| [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <0.00%> (-24.14%)` | `0.00% <0.00%> (ø%)` | |
| [.../filter/predicate/InPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL0luUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `55.17% <0.00%> (-11.50%)` | `0.00% <0.00%> (ø%)` | |
| [...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `42.50% <0.00%> (-8.13%)` | `0.00% <0.00%> (ø%)` | |
| [...e/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9TZWdtZW50U3RhdHVzQ2hlY2tlci5qYXZh) | `72.22% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/pinot/controller/LeadControllerManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9MZWFkQ29udHJvbGxlck1hbmFnZXIuamF2YQ==) | `68.68% <0.00%> (-2.03%)` | `0.00% <0.00%> (ø%)` | |
| [...ation/function/MinMaxRangeAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9NaW5NYXhSYW5nZUFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `76.25% <0.00%> (-1.25%)` | `0.00% <0.00%> (ø%)` | |
| [...routing/instanceselector/BaseInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0Jhc2VJbnN0YW5jZVNlbGVjdG9yLmphdmE=) | `93.06% <0.00%> (-1.00%)` | `0.00% <0.00%> (ø%)` | |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `70.91% <0.00%> (-0.58%)` | `0.00% <0.00%> (ø%)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-pinot/pull/6748/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=footer). Last update [913492e...b8346cf](https://codecov.io/gh/apache/incubator-pinot/pull/6748?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6748: fixing license headers and plugin checks
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748#discussion_r608246953
##########
File path: pom.xml
##########
@@ -1660,63 +1668,51 @@
</executions>
<configuration>
<excludes>
- <!-- Sphynx auto generated makefile -->
- <exclude>docs/Makefile</exclude>
-
- <!-- Exclude build files for docs -->
- <exclude>docs/_build/**</exclude>
-
<!-- Exclude license copies -->
<exclude>licenses/**</exclude>
<exclude>licenses-binary/**</exclude>
<!-- Exclude build targets -->
<exclude>**/target/**</exclude>
+ <!-- Text and log files -->
+ <exclude>**/*.txt</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/*.list</exclude>
+ <exclude>**/*.out</exclude>
+ <exclude>**/*.generated</exclude>
+ <exclude>**/java.sql.Driver</exclude>
+ <exclude>**/org.apache.spark.sql.sources.DataSourceRegister</exclude>
+
+ <!-- Binary files -->
+ <exclude>**/*.avro</exclude>
+ <exclude>**/*.avsc</exclude>
+ <exclude>**/*.csv</exclude>
+ <exclude>**/*.desc</exclude>
+ <exclude>**/*.parquet</exclude>
+ <exclude>**/*.gz</exclude>
+ <exclude>**/*.orc</exclude>
+ <exclude>**/*.dict</exclude>
+ <exclude>**/*.raw</exclude>
+ <exclude>**/*.mapping</exclude>
+ <exclude>**/*.ser</exclude>
+ <exclude>**/*.v1</exclude>
+ <exclude>**/*.v2</exclude>
+ <exclude>**/appAssemblerScriptTemplate</exclude>
<!-- js, css files that are exact copies of the third-party works. In this case, the original header has to
be kept. Please refer to 'Treatment of Third-party works' in https://www.apache.org/legal/src-headers.html
-->
- <exclude>**/codemirror/**</exclude>
- <exclude>**/codemirror*</exclude>
- <exclude>**/foundation*</exclude>
- <exclude>**/angular*</exclude>
- <exclude>**/underscore*</exclude>
- <exclude>**/jquery*</exclude>
- <exclude>**/normalize*</exclude>
- <exclude>**/handlebars*</exclude>
- <exclude>**/beautify*</exclude>
- <exclude>**/src/main/resources/.*</exclude>
- <exclude>**/src/main/resources/dist/**</exclude>
- <exclude>**/src/main/resources/node_modules/**</exclude>
-
- <!-- Binary files -->
- <exclude>**/*.json</exclude>
- <exclude>**/*.pql</exclude>
- <exclude>**/*.log</exclude>
- <exclude>**/*.csv</exclude>
- <exclude>**/*.avro</exclude>
- <exclude>**/*.conf</exclude>
- <exclude>**/*.config</exclude>
- <exclude>**/*.yml</exclude>
- <exclude>**/*.yaml</exclude>
- <exclude>**/*.properties</exclude>
+ <exclude>**/node_modules/**</exclude>
+ <exclude>**/dist/**</exclude>
+ <exclude>**/*.*rc</exclude>
<!-- IDE files -->
<exclude>**/*.iml</exclude>
<!-- Top level -->
<exclude>.codecov*</exclude>
Review comment:
Let's add header to `.codecov.yml` and remove this exclusion
##########
File path: rstheaderdefinition.xml
##########
@@ -30,4 +30,14 @@
<isMultiline>true</isMultiline>
<padLines>false</padLines>
</rst_style>
+ <javadoc_style>
Review comment:
Rename this file to `headerdefinitions.xml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6748: fixing license headers and plugin checks
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6748:
URL: https://github.com/apache/incubator-pinot/pull/6748#discussion_r608353308
##########
File path: pinot-spi/src/test/resources/pinot-configuration-3.properties
##########
@@ -1,2 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
controller.config-paths-multi-value-test-1=config-path-3-config-paths-multi-value-test-1
controller.config-paths-multi-value-test-2=config-path-3-config-paths-multi-value-test-2
Review comment:
Need one extra line?
##########
File path: pinot-distribution/pinot-source-assembly.xml
##########
@@ -36,26 +36,25 @@
<exclude>**/*.iws</exclude>
<exclude>**/*.log</exclude>
<exclude>**/.idea/**</exclude>
- <exclude>thirdeye/**</exclude>
<exclude>**/.travis/**</exclude>
Review comment:
You can also remove this line since there is no .travis dir any more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org