Re: Review Request 21968: Fix issue #878 Slave should not register with the master when in TERMINATING.

[Mesos ReviewBot <de...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21968/#review44478
-----------------------------------------------------------


Bad patch!

Reviews applied: [21968]

Failed command: git apply --index 21968.patch

Error:
 error: patch failed: src/slave/slave.cpp:800
error: src/slave/slave.cpp: patch does not apply


- Mesos ReviewBot


On May 30, 2014, 9:45 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21968/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 9:45 p.m.)
> 
> 
> Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-878
>     https://issues.apache.org/jira/browse/MESOS-878
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added a sentence to check the slave's state in doReliableRegistration() to make sure that the function returns when the slave's state is TERMINATING.
> Also, to write the test, I need to make sure there's no additional doReliableRegistration() calls, so I added NO_FUTURE_PROTOBUFS() and NO_FUTURE_MESSAGES() to make sure there's no more SlaveReregisteredMessages.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gmock.hpp daba7e3 
>   src/slave/slave.cpp 7fbedb1 
>   src/tests/mesos.hpp 1b0f358 
>   src/tests/slave_tests.cpp 80fe3cf 
> 
> Diff: https://reviews.apache.org/r/21968/diff/
> 
> 
> Testing
> -------
> 
> Slave_tests.cpp:TerminatingSlaveDoesNotReregister.
> 
> 
> File Attachments
> ----------------
> 
> Using DROP_PROTOBUF()
>   https://reviews.apache.org/media/uploaded/files/2014/05/30/7c0e1b69-19c1-4868-865e-d47fbb739585__mesos.diff
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>