You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/07 19:13:35 UTC
[GitHub] [tvm] comaniac commented on a change in pull request #7046: [Auto Scheduler] Add target host to measure record
comaniac commented on a change in pull request #7046:
URL: https://github.com/apache/tvm/pull/7046#discussion_r537759346
##########
File path: src/auto_scheduler/measure_record.cc
##########
@@ -183,7 +186,12 @@ struct Handler<::tvm::auto_scheduler::SearchTaskNode> {
reader->Read(hardware_params_node.get());
s = reader->NextArrayItem();
data->hardware_params = ::tvm::auto_scheduler::HardwareParams(hardware_params_node);
- ICHECK(!s);
+ if (s) {
+ reader->Read(&str_value);
+ data->target_host = ::tvm::Target(str_value);
+ s = reader->NextArrayItem();
+ ICHECK(!s);
Review comment:
This check should be out of this if-statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org