You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/01/05 00:53:57 UTC
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12164
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
IMPALA-8026: Fix #rows accounting for NLJ
Use the same, much simpler, approach used by all other ExecNodes.
Testing:
Manually tested by adding logging to print values of the counter.
Confirmed that the fix led to the counter having the correct
values (instead of values exceeding num_rows_returned_).
Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
---
M be/src/exec/nested-loop-join-node.cc
1 file changed, 8 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/12164/1
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 07 Jan 2019 21:12:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 07 Jan 2019 21:02:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
IMPALA-8026: Fix #rows accounting for NLJ
Use the same, much simpler, approach used by all other ExecNodes.
Testing:
Manually tested by adding logging to print values of the counter.
Confirmed that the fix led to the counter having the correct
values (instead of values exceeding num_rows_returned_).
Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Reviewed-on: http://gerrit.cloudera.org:8080/12164
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/nested-loop-join-node.cc
1 file changed, 8 insertions(+), 20 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3618/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 07 Jan 2019 21:12:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1718/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Jan 2019 01:21:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 )
Change subject: IMPALA-8026: Fix #rows accounting for NLJ
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e2e1d8f85478ff36c8cddc69bac3bdccd2c824
Gerrit-Change-Number: 12164
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 08 Jan 2019 01:22:28 +0000
Gerrit-HasComments: No