You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/20 07:15:47 UTC

[GitHub] [flink] yangjunhan commented on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

yangjunhan commented on pull request #18413:
URL: https://github.com/apache/flink/pull/18413#issuecomment-1017183214


   I have to explicitly add `@ant-design/icons-angular` as a dependency for `flink-runtime-web` even thought it is a dependency for NG-ZORRO.
   
   When I ran `npm install` under node v14.18.X, everything worked fine. But if I ran the former command under node v16.10.X, `@ant-design/icons-angular` did not install as expected. This may be caused by the fact that NG-ZORRO's package.json engines field still uses `^12.20.0 || ^14.0.0`, missing `^16.0.0` (according to [angular version guide](https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3)).
   
   Once NG-ZORRO fixes this issue, I can then safely remove this explicit dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org