[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6412: [TOPI][OpenCL]OpenCL accelerator support

[GitBox <gi...@apache.org>]

FrozenGene commented on a change in pull request #6412:
URL: https://github.com/apache/incubator-tvm/pull/6412#discussion_r486870572



##########
File path: src/runtime/opencl/opencl_common.h
##########
@@ -216,7 +216,8 @@ class OpenCLWorkspace : public DeviceAPI {
   // Initialzie the device.
   void Init(const std::string& type_key, const std::string& device_type,
             const std::string& platform_name = "");
-  virtual void Init() { Init("opencl", "gpu"); }
+  // Find accelerator first, TODO: Make a proper way to chose between device types
+  virtual void Init() { Init("opencl", "accelerator"); }

Review comment:
       I think we could have one discussion here. That is whether we should let `accelerator` be the first priority for OpenCL or we should do this like Intel FPGA (AOCL), for accelerator we create one new device type. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org