Re: [PR] fix: avoid warning spam when default spinner SVG is missing [superset]

["semohr (via GitHub)" <gi...@apache.org>]

semohr commented on code in PR #40481:
URL: https://github.com/apache/superset/pull/40481#discussion_r3333237198


##########
superset/views/base.py:
##########
@@ -449,7 +443,7 @@ def cached_common_bootstrap_data(  # pylint: disable=unused-argument
     # should not expose API TOKEN to frontend
     frontend_config = {
         k: (
-            list(app.config.get(k))
+            list(cast(Iterable[Any], app.config.get(k)))

Review Comment:
   Can we avoid the cast here somehow?
   
   In general, it's preferable to avoid casts whenever possible, since they can hide type issues from the type checker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org