You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/25 15:01:58 UTC
[jira] [Commented] (CB-12062) Cordova Splashscreen Plugin Crash due
to incorrect KVO observing
[ https://issues.apache.org/jira/browse/CB-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605548#comment-15605548 ]
ASF GitHub Bot commented on CB-12062:
-------------------------------------
GitHub user PaulTaykalo opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/117
CB-12062: (ios) Fix crash when listening for KVO changes for deallocated object
### Platforms affected
ios
### What does this PR do?
Fix crash when listening for KVO changes for deallocated object
### What testing has been done on this change?
Tests aded
### Checklist
- ✅ [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- ✅ Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- ✅ Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulTaykalo/cordova-plugin-splashscreen fix/kvo-crashing-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 58044c7b16ab84652b0545e19b1cdc8636d83c51
Author: Paul Taykalo <tt...@gmail.com>
Date: 2016-10-25T14:49:05Z
Fix crash when listening for KVO changes
----
> Cordova Splashscreen Plugin Crash due to incorrect KVO observing
> ----------------------------------------------------------------
>
> Key: CB-12062
> URL: https://issues.apache.org/jira/browse/CB-12062
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 3.5.0
> Reporter: Paul Taykalo
> Labels: ios
>
> Applicaiton Crashes unexpectedly if there's more then one cordova application due to incorrect Key-Value-Observing logic
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org