[jira] [Work logged] (ARTEMIS-2305) MESSAGES_ACKNOWLEDGED is incrememented even if message consumption is rolled back

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2305?focusedWorklogId=226841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226841 ]

ASF GitHub Bot logged work on ARTEMIS-2305:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/19 18:35
            Start Date: 12/Apr/19 18:35
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2618: ARTEMIS-2305 ACK counters to only increment after commit
URL: https://github.com/apache/activemq-artemis/pull/2618
 
 
   Also including a new metric for ack attempts that will keep the former semantic.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 226841)
            Time Spent: 10m
    Remaining Estimate: 0h

> MESSAGES_ACKNOWLEDGED is incrememented even if message consumption is rolled back
> ---------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2305
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2305
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> this is borderline between bug and improvement.
>  
> The ACKs management count is meant to always increment, whenever the ack is actually called.
>  
> Certain users want the information to be more strict, and only increment it after commit (if using transactions).
>  
> I'm adding a new metric called acknowledgeAttempts on QueueControl and QueueImpl and its interface



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)