[GitHub] [skywalking] wankai123 opened a new pull request #7672: Support etcd grouped dynamic configurations.

[GitBox <gi...@apache.org>]

wankai123 opened a new pull request #7672:
URL: https://github.com/apache/skywalking/pull/7672


   ### Support etcd grouped dynamic configurations.
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [X] Update the documentation to include this new feature.
   - [X] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #7672: Support etcd grouped dynamic configurations.

[GitBox <gi...@apache.org>]

wu-sheng merged pull request #7672:
URL: https://github.com/apache/skywalking/pull/7672


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7672: Support etcd grouped dynamic configurations.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7672:
URL: https://github.com/apache/skywalking/pull/7672#discussion_r703541028



##########
File path: docs/en/setup/backend/dynamic-config-etcd.md
##########
@@ -7,11 +7,54 @@ configuration:
   selector: ${SW_CONFIGURATION:etcd}
   etcd:
     period: ${SW_CONFIG_ETCD_PERIOD:60} # Unit seconds, sync period. Default fetch every 60 seconds.
-    endpoints: ${SW_CONFIG_ETCD_ENDPOINTS:localhost:2379}
+    endpoints: ${SW_CONFIG_ETCD_ENDPOINTS:http://localhost:2379}
     namespace: ${SW_CONFIG_ETCD_NAMESPACE:/skywalking}
     authentication: ${SW_CONFIG_ETCD_AUTHENTICATION:false}
     user: ${SW_CONFIG_ETCD_USER:}
     password: ${SW_CONFIG_ETCD_password:}
 ```
 
-**NOTE**: Only the v3 protocol is supported since 8.7.0.
\ No newline at end of file
+**NOTE**: Only the v3 protocol is supported since 8.7.0.
+
+## Config Storage
+### Single Config
+Single configs in etcd are key/value pairs:
+
+| Key | Value |
+|-----|-----|
+| {nameSpace}/configKey | configVaule |

Review comment:
       I just noticed this, please check all documents.
   
   ```suggestion
   | {namespace}/configKey | configVaule |
   ```
   
   `namespace` is one word.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org