You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mbutrovich (via GitHub)" <gi...@apache.org> on 2026/04/24 17:33:06 UTC

[PR] refactor(ipc): derive Default for CompressionContext [arrow-rs]

mbutrovich opened a new pull request, #9809:
URL: https://github.com/apache/arrow-rs/pull/9809

   # Which issue does this PR close?
   
   Follow-up to #9808.
   
   # Rationale for this change
   
   After #9808 changed the zstd `Compressor` field to `Option`, the manual `impl Default` for `CompressionContext` just sets it to `None`, which is identical to the derived `Default`. The `#[allow(clippy::derivable_impls)]` annotation confirms this was already a known issue.
   
   # What changes are included in this PR?
   
   Replace the manual `impl Default for CompressionContext` with `#[derive(Default)]` and remove the `clippy::derivable_impls` allow.
   
   # Are these changes tested?
   
   Existing tests cover this. The struct's default behavior is unchanged.
   
   # Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(ipc): derive Default for CompressionContext [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9809:
URL: https://github.com/apache/arrow-rs/pull/9809


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(ipc): derive Default for CompressionContext [arrow-rs]

Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on PR #9809:
URL: https://github.com/apache/arrow-rs/pull/9809#issuecomment-4315197629

   CC @alamb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org