[jira] [Resolved] (FELIX-6669) Flaw in OOM Fix for JSON CommentStripping

["Robert Munteanu (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu resolved FELIX-6669.
------------------------------------
    Resolution: Fixed

PR applied, thanks [~dsuess] for the follow-up!

> Flaw in OOM Fix for JSON CommentStripping
> -----------------------------------------
>
>                 Key: FELIX-6669
>                 URL: https://issues.apache.org/jira/browse/FELIX-6669
>             Project: Felix
>          Issue Type: Bug
>    Affects Versions: cm.json-2.0.2
>            Reporter: Dominik Süß
>            Assignee: Robert Munteanu
>            Priority: Major
>             Fix For: cm.json-2.0.4
>
>
> While applying the patched version to some more real world data I noticed that I missed a crucial condition that's not been covered in the unit tests so far: comments and parts of the tokens within String properties.
> To fix this I'll provide a patch that will take care of detecting when a string property or comment is starting and ending and only consider the handling for the other after the end token has been found. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)