You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/15 18:02:56 UTC
[GitHub] [airflow] josh-fell opened a new pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
josh-fell opened a new pull request #17036:
URL: https://github.com/apache/airflow/pull/17036
Closes: #16891
Creating an operator to extract data from Salesforce and upload to S3: `SalesforceToS3Operator`
Items contained in this PR include:
- Operator code: `airflow/providers/amazon/aws/transfers/salesforce_to_s3.py`
- Operator documentation: `docs/apache-airflow-providers-amazon/operators/salesforce_to_s3.rst`
- Operator unit test: `tests/providers/amazon/aws/transfers/test_salesforce_to_s3.py`
- Example DAG: `airflow/providers/amazon/aws/example_dags/example_salesforce_to_s3.py`
- Updated Amazon `provider.yaml`
Please let me know if I am missing any required updates when adding to provider packages.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell edited a comment on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell edited a comment on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742
~~@potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #17036:
URL: https://github.com/apache/airflow/pull/17036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882803379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell edited a comment on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell edited a comment on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742
~~@potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #17036:
URL: https://github.com/apache/airflow/pull/17036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882796877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742
@potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882796877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882814671
No problem. This happens often too. We move fast! and sometimes the best thing is to close and apply changes from the scratch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882796877
Can you please rebase to latest main ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #17036:
URL: https://github.com/apache/airflow/pull/17036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882802424
some rebase issue :( we have now 151 files changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882804908
> Yeah I'm looking into this. Sorry Jarek.
No problem. Happens to me often enough to mess up with rebase :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882803379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882803379
> some rebase issue :( we have now 151 files changed
Yeah I'm looking into this. Sorry Jarek.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell edited a comment on pull request #17036: Adding `SalesforceToS3Operator` to the Amazon Provider
Posted by GitBox <gi...@apache.org>.
josh-fell edited a comment on pull request #17036:
URL: https://github.com/apache/airflow/pull/17036#issuecomment-882813742
~~@potiuk Would you mind closing this PR? I'll open a new one. Sorry for really mucking this up.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org