You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/11 16:59:04 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
KacerCZ opened a new pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249
https://issues.apache.org/jira/browse/NETBEANS-4571
Added standard configuration files of PHP static analysis tools to Important Files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#discussion_r453276752
##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/ImportantFilesImpl.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.php.analysis;
+
+import java.util.Collection;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.modules.php.analysis.commands.CodeSniffer;
+import org.netbeans.modules.php.analysis.commands.CodingStandardsFixer;
+import org.netbeans.modules.php.analysis.commands.PHPStan;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesImplementation;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesSupport;
+import org.netbeans.spi.project.ProjectServiceProvider;
+
+@ProjectServiceProvider(service = ImportantFilesImplementation.class, projectType = "org-netbeans-modules-php-project") // NOI18N
+public final class ImportantFilesImpl implements ImportantFilesImplementation {
+
+ private final ImportantFilesSupport support;
+
+
+ public ImportantFilesImpl(Project project) {
+ assert project != null;
+ support = ImportantFilesSupport.create(project.getProjectDirectory(),
+ CodeSniffer.CONFIG_FILE_NAME,
+ CodeSniffer.DOT_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_DOT_CONFIG_FILE_NAME,
+ CodingStandardsFixer.CONFIG_FILE_NAME,
+ CodingStandardsFixer.DIST_CONFIG_FILE_NAME,
+ PHPStan.CONFIG_FILE_NAME,
+ PHPStan.DIST_CONFIG_FILE_NAME);
Review comment:
I agree. I moved list of file names to field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#discussion_r453263313
##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/ImportantFilesImpl.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.php.analysis;
+
+import java.util.Collection;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.modules.php.analysis.commands.CodeSniffer;
+import org.netbeans.modules.php.analysis.commands.CodingStandardsFixer;
+import org.netbeans.modules.php.analysis.commands.PHPStan;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesImplementation;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesSupport;
+import org.netbeans.spi.project.ProjectServiceProvider;
+
+@ProjectServiceProvider(service = ImportantFilesImplementation.class, projectType = "org-netbeans-modules-php-project") // NOI18N
+public final class ImportantFilesImpl implements ImportantFilesImplementation {
+
+ private final ImportantFilesSupport support;
+
+
+ public ImportantFilesImpl(Project project) {
+ assert project != null;
+ support = ImportantFilesSupport.create(project.getProjectDirectory(),
+ CodeSniffer.CONFIG_FILE_NAME,
+ CodeSniffer.DOT_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_DOT_CONFIG_FILE_NAME,
+ CodingStandardsFixer.CONFIG_FILE_NAME,
+ CodingStandardsFixer.DIST_CONFIG_FILE_NAME,
+ PHPStan.CONFIG_FILE_NAME,
+ PHPStan.DIST_CONFIG_FILE_NAME);
Review comment:
Nitpick: I would separate these from here. e.g. add the field or add the get method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#issuecomment-660202030
@junichi11 @tmysik Thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#discussion_r453263313
##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/ImportantFilesImpl.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.php.analysis;
+
+import java.util.Collection;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.project.Project;
+import org.netbeans.modules.php.analysis.commands.CodeSniffer;
+import org.netbeans.modules.php.analysis.commands.CodingStandardsFixer;
+import org.netbeans.modules.php.analysis.commands.PHPStan;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesImplementation;
+import org.netbeans.modules.php.spi.phpmodule.ImportantFilesSupport;
+import org.netbeans.spi.project.ProjectServiceProvider;
+
+@ProjectServiceProvider(service = ImportantFilesImplementation.class, projectType = "org-netbeans-modules-php-project") // NOI18N
+public final class ImportantFilesImpl implements ImportantFilesImplementation {
+
+ private final ImportantFilesSupport support;
+
+
+ public ImportantFilesImpl(Project project) {
+ assert project != null;
+ support = ImportantFilesSupport.create(project.getProjectDirectory(),
+ CodeSniffer.CONFIG_FILE_NAME,
+ CodeSniffer.DOT_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_CONFIG_FILE_NAME,
+ CodeSniffer.DIST_DOT_CONFIG_FILE_NAME,
+ CodingStandardsFixer.CONFIG_FILE_NAME,
+ CodingStandardsFixer.DIST_CONFIG_FILE_NAME,
+ PHPStan.CONFIG_FILE_NAME,
+ PHPStan.DIST_CONFIG_FILE_NAME);
Review comment:
Nitpick: I would separate these from here. e.g. add the field or add the get method
cc: @tmysik
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#issuecomment-658594169
Build failure was caused by network connection problem and is not related to content of PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2249: [NETBEANS-4571] Show PHP Static Analysis configuration files in Important Files
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2249:
URL: https://github.com/apache/netbeans/pull/2249#issuecomment-658579658
@KacerCZ Looks good to me but please verify the test failures, thanks.
@junichi11 Once everything is OK for you, feel free to merge. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists