You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/26 19:49:16 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #16960: [BEAM-14005] Fix ignored exception in BatchSpannerRead

chamikaramj commented on a change in pull request #16960:
URL: https://github.com/apache/beam/pull/16960#discussion_r815347410



##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -373,19 +379,12 @@ public void testReadMetrics() throws Exception {
             any(ReadQueryUpdateTransactionOption.class)))
         .thenReturn(Arrays.asList(fakePartition, fakePartition, fakePartition));
     when(mockBatchTx.execute(any(Partition.class)))
-        .thenThrow(

Review comment:
       Should we also keep the exception in this test and catch it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org