You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2026/10/18 14:36:07 UTC
[PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
morningman opened a new pull request, #69238:
URL: https://github.com/apache/doris/pull/69238
### What problem does this PR solve?
Issue Number: None
Related PR: #62058, #63643, #63850, #64133, #65810
Problem Summary:
**In short.** Row binlog (`binlog.format = 'ROW'`) was reworked several times on master. The reworks left dead code behind, and they deleted thrift / protobuf fields without retiring their ids. This PR deletes the dead code and retires the ids: `reserved` in protobuf, a `// N: deprecated <name>` comment in thrift. After this, no later change can reuse an id that an older master build may have persisted or sent. Nothing that runs today changes. This is also groundwork for renaming row binlog to changelog: code deleted here does not have to be renamed there.
**Background.**
- #62058 and #63643 first kept row binlog inside the base tablet. The tablet meta carried its own binlog schema and rowset metas (`row_binlog_schema`, `row_binlog_rs_metas`, `row_binlog_schema_hash`). Delete bitmaps had an `is_binlog_delvec` flag. Clone and snapshot requests had a `copy_type`. Tablet reports carried `binlog_size` / `binlog_file_num`, which the FE kept on `Replica`.
- #63850 added `binlog_timestamp_col_idx` / `binlog_lsn_col_idx` to the tablet schema. #64133 replaced them with `binlog_{tso,lsn,op}_col_idx` under new ids (41-43, and 42-44 in the cloud message). So the name `binlog_lsn_col_idx` is still in use, but under a new id.
- #65810 moved row binlog into an independent companion tablet. Most of the per-tablet fields above were deleted then. #65810 also added a thrift `TTabletWithPartition.binlog_tablet_id`, which nothing uses.
**The problem.**
- Ten protobuf ids and six thrift ids were deleted without being retired. `gensrc/AGENTS.md` requires a deleted id to be retired so it is never reused. Protobuf is the risky case: these messages are persisted in tablet meta (local RocksDB, and the cloud meta-service). Suppose a later field took one of these ids with another type or meaning. A tablet meta written by an older master build could then be decoded into the new field.
- Some code that nothing reaches is still there. FE `Replica` still carries `binlogSize` / `binlogFileNum` and writes them into the image, though nothing has set them since #65810. The thrift `TTabletWithPartition.binlog_tablet_id` was never used. The BE has unused constants, a method and two error codes. Without this PR, the changelog rename would have to rename all of it.
**How this PR fixes it.**
Dead code removed:
| Item | Why it is dead |
|---|---|
| thrift `TTabletWithPartition.binlog_tablet_id` (3) | `TTabletWithPartition` only lives inside the BE (`VTabletWriter`); field 3 is never set or read. The load path carries the companion tablet id in the protobuf `PTabletWithPartition.binlog_tablet_id`, which stays. |
| FE `Replica.binlogSize` / `binlogFileNum` (Gson `bs` / `bfn`) and their getters / setters | Their only writers, the tablet report fields, were removed in #65810; nothing reads them. Gson skips the two keys when it loads an image written by an older master. |
| BE `kRowBinlogPrefix`, `FDRowBinlogSuffix`, `Tablet::enable_row_binlog()` | No references. |
| BE error codes `BINLOG_COMPACTION_INVALID_PARAMETERS` (-2011), `BINLOG_COMPACTION_NO_SUITABLE_VERSION` (-2012) | No references. Removed the same way -2007 was, without a placeholder. |
Retired ids:
| File | Message | Ids | Old fields |
|---|---|---|---|
| olap_file.proto | `TabletMetaPB` | 42, 43, 44 | `row_binlog_schema`, `row_binlog_rs_metas`, `row_binlog_schema_hash` |
| olap_file.proto | `TabletMetaCloudPB` | 43, 44 | `row_binlog_rs_metas`, `row_binlog_schema_hash` |
| olap_file.proto | `TabletSchemaPB` / `TabletSchemaCloudPB` | 37, 38 / 38, 39 | `binlog_timestamp_col_idx`, `binlog_lsn_col_idx` (the old ids only; see Background) |
| olap_file.proto | `DeleteBitmapPB` | 5 | `is_binlog_delvec` |
| AgentService.thrift | `TCloneReq` / `TSnapshotRequest` | 14 / 15 | `copy_type` |
| BackendService.thrift | `TTabletStat` | 12, 13 | `binlog_size`, `binlog_file_num` |
| MasterService.thrift | `TTabletInfo` | 26, 27 | `binlog_size`, `binlog_file_num` |
| PaloInternalService.thrift | `TTabletWithPartition` | 3 | `binlog_tablet_id` |
None of these ids is used on branch-4.2, branch-4.1, branch-4.0 or branch-3.1 (checked with `git show` on each branch), so retiring them agrees with every release. `TabletMetaCloudPB` 42 is not in the table: it already means something else on master (it was `row_binlog_schema`, it is now `binlog_tablet_id`). This PR cannot undo that.
Not included: `TTabletSchema.binlog_{tso,lsn,op}_idx` (28-30). The FE stopped sending them in #65810, but BE unit tests still set them when they create a companion tablet. Whether production needs them is a separate question, left to a follow-up.
**Results.**
- No behavior change. The one thrift field deleted here was never set, the other thrift changes are comments, and `reserved` only makes protoc reject a future reuse of the id.
- A peer built from an older master that still sends one of the deleted thrift fields has it skipped as an unknown field, as it already is today. An FE image that still has `bs` / `bfn` loads as before.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Build: `build.sh --fe --be` (BE Release; FE with checkstyle).
- FE unit tests (`run-fe-ut.sh`): `ReplicaTest` (5), `TabletTest` (11), `OlapTableTest` (18), all pass.
- No BE unit test: nothing under `be/test` references the removed symbols (`git grep`).
- Cloud was not built locally. It only sees the new `reserved` lines, which do not change the generated code.
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6251159721
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6253534055
# FE Regression Coverage Report
Increment line coverage ` 100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6252001050
<details>
<summary>TPC-DS: <b>Total hot run time: 151510 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b7a4abf106943203a088d0491d9badbb9870a191, data reload: false
query5 4304 594 451 451
query6 431 205 189 189
query7 4809 439 228 228
query8 318 168 156 156
query9 8748 3929 3948 3929
query10 488 313 270 270
query11 6035 3795 3500 3500
query12 157 91 85 85
query13 1255 420 327 327
query14 6164 4006 3751 3751
query14_1 3523 3526 3557 3526
query15 206 198 180 180
query16 929 440 446 440
query17 826 640 515 515
query18 2401 419 301 301
query19 191 166 124 124
query20 81 79 83 79
query21 204 131 110 110
query22 12956 12949 12733 12733
query23 13438 12659 12585 12585
query23_1 12548 12591 12439 12439
query24 7071 806 452 452
query24_1 461 463 460 460
query25 507 385 340 340
query26 1279 253 132 132
query27 2787 443 260 260
query28 4623 1978 1948 1948
query29 1544 582 427 427
query30 284 221 179 179
query31 1021 925 798 798
query32 142 91 85 85
query33 500 329 243 243
query34 959 852 495 495
query35 773 782 630 630
query36 867 778 714 714
query37 126 93 88 88
query38 1805 1766 1729 1729
query39 781 833 747 747
query39_1 726 736 736 736
query40 217 114 93 93
query41 68 62 60 60
query42 83 78 77 77
query43 358 382 319 319
query44 1290 700 703 700
query45 182 182 156 156
query46 841 963 570 570
query47 2862 3018 2912 2912
query48 289 298 211 211
query49 566 413 295 295
query50 666 271 216 216
query51 10432 10628 10321 10321
query52 81 81 68 68
query53 179 211 158 158
query54 248 195 176 176
query55 73 68 64 64
query56 218 216 225 216
query57 1597 1565 1539 1539
query58 291 264 251 251
query59 2171 2211 1918 1918
query60 281 238 231 231
query61 144 143 143 143
query62 388 346 289 289
query63 199 162 162 162
query64 2753 1054 767 767
query65 3293 3259 3248 3248
query66 1763 435 304 304
query67 20263 20233 19983 19983
query68 3324 987 599 599
query69 405 298 242 242
query70 871 822 774 774
query71 291 239 207 207
query72 2871 2618 2285 2285
query73 528 516 292 292
query74 4639 4455 4279 4279
query75 2338 2296 1929 1929
query76 2347 1019 611 611
query77 346 378 283 283
query78 9791 9620 9056 9056
query79 877 844 518 518
query80 491 416 351 351
query81 507 324 267 267
query82 221 136 115 115
query83 197 190 182 182
query84 281 118 105 105
query85 757 417 365 365
query86 254 239 240 239
query87 2004 1936 1809 1809
query88 3577 2705 2692 2692
query89 319 298 256 256
query90 2053 180 174 174
query91 161 149 125 125
query92 95 88 87 87
query93 995 990 578 578
query94 447 311 298 298
query95 602 346 379 346
query96 668 520 235 235
query97 2452 2452 2305 2305
query98 161 150 146 146
query99 766 761 665 665
Total cold run time: 233671 ms
Total hot run time: 151510 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6252733200
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69238:
URL: https://github.com/apache/doris/pull/69238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6262603946
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6253520513
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/b7a4abf106943203a088d0491d9badbb9870a191_b7a4abf106943203a088d0491d9badbb9870a191/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/b7a4abf106943203a088d0491d9badbb9870a191_b7a4abf106943203a088d0491d9badbb9870a191/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 66.37% (31729/47806) |
| Line Coverage | 51.13% (334195/653664) |
| Region Coverage | 46.47% (270027/581063) |
| Branch Coverage | 48.19% (127204/263952) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6252097978
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6251160903
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6251902657
<details>
<summary>TPC-H: <b>Total hot run time: 29556 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b7a4abf106943203a088d0491d9badbb9870a191, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17413 5614 5537 5537
q2 2079 308 243 243
q3 10172 1437 845 845
q4 4676 476 342 342
q5 7444 790 532 532
q6 213 191 154 154
q7 768 788 610 610
q8 9270 1350 1093 1093
q9 5797 4308 4264 4264
q10 6866 1286 1033 1033
q11 446 250 235 235
q12 644 396 287 287
q13 18122 3596 2995 2995
q14 276 273 244 244
q15 q16 760 726 673 673
q17 1232 752 575 575
q18 7173 6229 6213 6213
q19 1100 959 593 593
q20 402 341 229 229
q21 5440 2577 2600 2577
q22 382 389 282 282
Total cold run time: 100675 ms
Total hot run time: 29556 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6478 6494 6395 6395
q2 747 592 580 580
q3 5550 5679 5238 5238
q4 2329 2148 1582 1582
q5 5869 5663 5801 5663
q6 249 192 152 152
q7 2269 2017 1830 1830
q8 3123 2533 2513 2513
q9 7653 7635 7580 7580
q10 3639 3585 3231 3231
q11 596 398 383 383
q12 694 691 495 495
q13 3192 3520 3029 3029
q14 289 289 271 271
q15 q16 648 687 608 608
q17 7826 6988 6892 6892
q18 13060 12289 13072 12289
q19 938 791 801 791
q20 2176 2179 1931 1931
q21 5740 4689 4814 4689
q22 507 481 415 415
Total cold run time: 73572 ms
Total hot run time: 66557 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6252050929
<details>
<summary>ClickBench: <b>Total hot run time: 25.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b7a4abf106943203a088d0491d9badbb9870a191, data reload: false
query1 0.00 0.01 0.00
query2 0.15 0.08 0.08
query3 0.36 0.21 0.19
query4 1.61 0.21 0.21
query5 0.31 0.28 0.29
query6 1.16 0.66 0.66
query7 0.04 0.01 0.00
query8 0.09 0.08 0.08
query9 0.47 0.36 0.37
query10 0.58 0.59 0.59
query11 0.31 0.17 0.17
query12 0.32 0.19 0.18
query13 0.51 0.51 0.52
query14 0.93 0.93 0.93
query15 0.67 0.58 0.58
query16 0.36 0.37 0.35
query17 1.02 1.00 1.03
query18 0.30 0.29 0.27
query19 1.94 1.87 1.81
query20 0.02 0.02 0.01
query21 15.39 0.33 0.30
query22 4.79 0.12 0.14
query23 15.86 0.48 0.29
query24 2.41 0.54 0.39
query25 0.14 0.10 0.10
query26 0.73 0.28 0.20
query27 0.10 0.09 0.09
query28 3.57 0.88 0.44
query29 12.55 4.36 3.45
query30 0.37 0.23 0.21
query31 2.76 0.59 0.34
query32 3.21 0.62 0.52
query33 3.07 3.01 2.95
query34 15.93 4.16 3.46
query35 3.40 3.37 3.41
query36 0.58 0.50 0.50
query37 0.12 0.10 0.09
query38 0.07 0.06 0.07
query39 0.06 0.06 0.05
query40 0.18 0.17 0.15
query41 0.10 0.05 0.05
query42 0.06 0.06 0.05
query43 0.06 0.06 0.06
Total cold run time: 96.66 s
Total hot run time: 25.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6262604515
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6253565913
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69238_b7a4abf106943203a088d0491d9badbb9870a191_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 77.21% (35771/46327) |
| Line Coverage | 62.43% (403708/646679) |
| Region Coverage | 58.82% (340550/578973) |
| Branch Coverage | 59.83% (157534/263311) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](row-binlog) Remove dead code and reserve retired field ids [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69238:
URL: https://github.com/apache/doris/pull/69238#issuecomment-6251559479
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/b7a4abf106943203a088d0491d9badbb9870a191_b7a4abf106943203a088d0491d9badbb9870a191_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/b7a4abf106943203a088d0491d9badbb9870a191_b7a4abf106943203a088d0491d9badbb9870a191_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 77.98% (2079/2666) |
| Line Coverage | 66.21% (38274/57806) |
| Region Coverage | 53.67% (35901/66898) |
| Branch Coverage | 57.08% (11544/20225) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org