You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/22 16:57:44 UTC
Review Request 70281: Added stream operator overload for
OperationStatus messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70281/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
This commit adds a new overload
ostream& operator<<(ostream&, const OperationStatus&);
to make the printing of OperationStatus messages
more convenient.
Diffs
-----
include/mesos/v1/mesos.hpp dc328bf45d8b69dcf096785b98031513b7ea9099
src/v1/mesos.cpp 704ad7697689d9cb21d6ed2675ac6c0044ce18c8
Diff: https://reviews.apache.org/r/70281/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70281: Added stream operator overload for
OperationStatus messages.
Posted by Benno Evers <be...@mesosphere.com>.
> On March 27, 2019, 3:11 p.m., Benjamin Bannier wrote:
> > Looks good. Any testing you'd like to document?
Sure, updated the description.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70281/#review214110
-----------------------------------------------------------
On March 22, 2019, 4:57 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70281/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 4:57 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a new overload
>
> ostream& operator<<(ostream&, const OperationStatus&);
>
> to make the printing of OperationStatus messages
> more convenient.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp dc328bf45d8b69dcf096785b98031513b7ea9099
> src/v1/mesos.cpp 704ad7697689d9cb21d6ed2675ac6c0044ce18c8
>
>
> Diff: https://reviews.apache.org/r/70281/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70281: Added stream operator overload for
OperationStatus messages.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70281/#review214110
-----------------------------------------------------------
Ship it!
Looks good. Any testing you'd like to document?
- Benjamin Bannier
On March 22, 2019, 5:57 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70281/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 5:57 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a new overload
>
> ostream& operator<<(ostream&, const OperationStatus&);
>
> to make the printing of OperationStatus messages
> more convenient.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp dc328bf45d8b69dcf096785b98031513b7ea9099
> src/v1/mesos.cpp 704ad7697689d9cb21d6ed2675ac6c0044ce18c8
>
>
> Diff: https://reviews.apache.org/r/70281/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>